Skip to content

Commit

Permalink
refactor: [M3-6478] - Make <Select /> type safe (#8986)
Browse files Browse the repository at this point in the history
drastically improves the type safety and DX of the `<Select />` component

---------

Co-authored-by: Banks Nussman <banks@nussman.us>
  • Loading branch information
bnussman-akamai and bnussman authored Apr 14, 2023
1 parent 49af3bf commit 65b6b01
Show file tree
Hide file tree
Showing 34 changed files with 697 additions and 764 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/) and this p
- `<RegionSelect />` can now dynamically get country flag and group all countrys #8996

### Fixed:
- Typesafety of the `<Select />` component #8986
- Clear the Kubernetes Delete Dialog when it is re-opened #9000

### Tech Stories:
Expand Down
1 change: 0 additions & 1 deletion packages/manager/src/GoTo.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,6 @@ const GoTo: React.FC<CombinedProps> = (props) => {
openMenuOnClick={false}
isClearable={false}
isMulti={false}
value={false}
menuIsOpen={true}
/>
</div>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ export const SelectTemplate = (args) => {
<div id="drop-down-story">
<Select
onChange={onSelect}
createNew={create}
onCreateOption={create}
value={isMulti ? selectedItems : selectedItem}
{...args}
/>
Expand Down
Loading

0 comments on commit 65b6b01

Please sign in to comment.