feedback @coliu-akamai @hkhalil-akamai

linode · Dec 10, 2024 · d7524d0 · d7524d0
1 parent 20a009a
commit d7524d0
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 11 deletions.
diff --git a/packages/manager/src/hooks/useOrderV2.test.tsx b/packages/manager/src/hooks/useOrderV2.test.tsx
@@ -106,7 +106,7 @@ describe('useOrderV2', () => {
     });
   });
 
-  it.only('should update URL and preferences when handleOrderChange is called', async () => {
+  it('should update URL and preferences when handleOrderChange is called', async () => {
     const mutatePreferencesMock = vi.fn();
     server.use(
       http.put('*/profile/preferences', async ({ request }) => {

diff --git a/packages/manager/src/routes/volumes/index.ts b/packages/manager/src/routes/volumes/index.ts
@@ -45,6 +45,11 @@ const volumesCreateRoute = createRoute({
   import('./volumesLazyRoutes').then((m) => m.volumeCreateLazyRoute)
 );
 
+type VolumeActionRouteParams<P = number | string> = {
+  action: VolumeAction;
+  volumeId: P;
+};
+
 const volumeActionRoute = createRoute({
   beforeLoad: async ({ params }) => {
     if (!(params.action in volumeAction)) {
@@ -55,16 +60,16 @@ const volumeActionRoute = createRoute({
     }
   },
   getParentRoute: () => volumesRoute,
-  parseParams: ({
-    action,
-    volumeId,
-  }: {
-    action: VolumeAction;
-    volumeId: string;
-  }) => ({
-    action,
-    volumeId: Number(volumeId),
-  }),
+  params: {
+    parse: ({ action, volumeId }: VolumeActionRouteParams<string>) => ({
+      action,
+      volumeId: Number(volumeId),
+    }),
+    stringify: ({ action, volumeId }: VolumeActionRouteParams<number>) => ({
+      action,
+      volumeId: String(volumeId),
+    }),
+  },
   path: '$volumeId/$action',
   validateSearch: (search: VolumesSearchParams) => search,
 }).lazy(() =>