Skip to content

Commit

Permalink
fix: [M3-8142] - Alignment Regression Of The IP Address Inside Node P…
Browse files Browse the repository at this point in the history
…ools Table (#10599)

* Fix alignment issue of the IP Address in Node Pools table

* Add changeset

* Implement PR feedback

* More PR feedback

* Comment out gecko2 mock flags causing clone-linode spec to fail
  • Loading branch information
carrillo-erik authored Jul 1, 2024
1 parent e64101c commit f16aaaa
Show file tree
Hide file tree
Showing 4 changed files with 17 additions and 11 deletions.
5 changes: 5 additions & 0 deletions packages/manager/.changeset/pr-10599-fixed-1718922229335.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@linode/manager": Fixed
---

Visual bug inside Node Pools Table ([#10599](https://github.com/linode/manager/pull/10599))
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import { APIError } from '@linode/api-v4/lib/types';
import Grid from '@mui/material/Unstable_Grid2';
import * as React from 'react';
import { Link } from 'react-router-dom';
Expand All @@ -13,6 +12,8 @@ import { useInProgressEvents } from 'src/queries/events/events';
import NodeActionMenu from './NodeActionMenu';
import { StyledCopyTooltip, StyledTableRow } from './NodeTable.styles';

import type { APIError } from '@linode/api-v4/lib/types';

export interface NodeRow {
instanceId?: number;
instanceStatus?: string;
Expand Down Expand Up @@ -100,7 +101,7 @@ export const NodeRow = React.memo((props: NodeRowProps) => {
</>
)}
</TableCell>
<TableCell>
<TableCell noWrap>
{linodeError ? (
<Typography
sx={(theme) => ({
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ import { TableSortCell } from 'src/components/TableSortCell';
import { TooltipIcon } from 'src/components/TooltipIcon';
import { Typography } from 'src/components/Typography';
import { useAllLinodesQuery } from 'src/queries/linodes/linodes';
import { LinodeWithMaintenance } from 'src/utilities/linodes';

import { NodeRow as _NodeRow } from './NodeRow';
import {
Expand All @@ -30,6 +29,7 @@ import {
import type { NodeRow } from './NodeRow';
import type { PoolNodeResponse } from '@linode/api-v4/lib/kubernetes';
import type { EncryptionStatus } from '@linode/api-v4/lib/linodes/types';
import type { LinodeWithMaintenance } from 'src/utilities/linodes';

export interface Props {
encryptionStatus: EncryptionStatus | undefined;
Expand Down Expand Up @@ -88,7 +88,7 @@ export const NodeTable = React.memo((props: Props) => {
<TableSortCell
sx={(theme) => ({
...theme.applyTableHeaderStyles,
width: '35%',
width: '25%',
})}
active={orderBy === 'instanceStatus'}
direction={order}
Expand All @@ -100,7 +100,7 @@ export const NodeTable = React.memo((props: Props) => {
<TableSortCell
sx={(theme) => ({
...theme.applyTableHeaderStyles,
width: '15%',
width: '35%',
})}
active={orderBy === 'ip'}
direction={order}
Expand Down
12 changes: 6 additions & 6 deletions packages/manager/src/hooks/useFlags.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import { useFlags as ldUseFlags } from 'launchdarkly-react-client-sdk';
import { useSelector } from 'react-redux';

import { FlagSet } from 'src/featureFlags';
import { ApplicationState } from 'src/store';
import type { FlagSet } from 'src/featureFlags';
import type { ApplicationState } from 'src/store';
export { useLDClient } from 'launchdarkly-react-client-sdk';

/**
Expand All @@ -29,9 +29,9 @@ export const useFlags = () => {
return {
...flags,
...mockFlags,
gecko2: {
enabled: true,
ga: true,
},
// gecko2: {
// enabled: true,
// ga: true,
// },
};
};

0 comments on commit f16aaaa

Please sign in to comment.