-
Notifications
You must be signed in to change notification settings - Fork 367
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
change: [M3-8533, M3-8761] - Fix firewall rules table and Replace `re…
…act-beautiful-dnd` with `dnd-kit` lib (#11127) * Fix firewall rules table * Update the comment * Added changeset: Broken firewall rules table * Keeping PolicyRow to 2 grids for sm breakpoint * Add padding to headers and cells * Add line height to StyledHeaderItemBox * Update some styles * Update styles * Fix broken firewall rules table and replace react-beautiful-dnd with dnd-kit * Set cursor style to 'grab' or 'grabbing' based on drag state * isDragging state var pos fix * Add TouchSensor and collisionDetection * Add width to table cells for improved layout * Some cleanup... * Update width * Fix colors for pending deletion row and clean up styling for rule btn * Added changeset: Broken firewall rules table * Added changeset: Replace `react-beautiful-dnd` with `dnd-kit` library * Remove react-beautiful-dnd from the codebase * Remove react-beautiful-dnd from the codebase * Remove initial pos focus on drag end and enable rows to drag over others * Refactoring... * Update firewall e2e tests * Adjust label column to prevent text wrapping on mobile and some clean up... * Improve smoothness of row dragging * overflow logic & styling * add missing keyboard sensor * Fix weird scalling with varying row heights and enable drag on navs as well * Remove Label col nowrap to keep table inplace on overflow and some adjustments * revert overflow issue * revert overflow issue * fix sortable via keyboard behavior * Clean up imports * Fix scrolling behavior when using keyboard keys * Add changeset and fix typo * Fix focus reset when dragging elements via keyboard * Add theme compatible background color focus --------- Co-authored-by: Alban Bailly <abailly@akamai.com>
- Loading branch information
1 parent
bea1ccc
commit f3a9f37
Showing
11 changed files
with
569 additions
and
299 deletions.
There are no files selected for viewing
5 changes: 5 additions & 0 deletions
5
packages/manager/.changeset/pr-11127-changed-1729515938754.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@linode/manager": Changed | ||
--- | ||
|
||
Replace `react-beautiful-dnd` with `dnd-kit` library ([#11127](https://github.com/linode/manager/pull/11127)) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@linode/manager": Fixed | ||
--- | ||
|
||
Broken firewall rules table ([#11127](https://github.com/linode/manager/pull/11127)) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@linode/manager": Fixed | ||
--- | ||
|
||
Table component styling issue for `noOverflow` property ([#11127](https://github.com/linode/manager/pull/11127)) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 2 additions & 1 deletion
3
packages/manager/src/features/Firewalls/FirewallDetail/Rules/FirewallRuleTable.test.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.