-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing Linode Power #1
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| import sinon from 'sinon'; | ||
| import { expect } from 'chai'; | ||
| import * as fetch from '~/fetch'; | ||
| import { | ||
| powerOnLinode, | ||
| powerOffLinode, | ||
| rebootLinode | ||
| } from '../../../src/actions/api/linodes'; | ||
| import * as linode_actions from '../../../src/actions/api/linodes'; | ||
| import { mock_context } from '../../api-store.spec.js'; | ||
|
|
||
| describe("actions/linodes/power", sinon.test(() => { | ||
| it('returns linode power boot status', async () => { | ||
| await mock_context(async ({ | ||
| auth, dispatch, getState, fetchStub | ||
| }) => { | ||
| const f = powerOnLinode("foo"); | ||
|
|
||
| await f(dispatch, getState); | ||
|
|
||
| sinon.assert.calledWith(fetchStub, | ||
| auth.token, '/linodes/foo/boot', { method: "POST" }); | ||
| sinon.assert.calledWith(dispatch, { | ||
| type: linode_actions.UPDATE_LINODE, | ||
| linode: { id: "foo", state: "booting" } | ||
| }); | ||
| }, { | ||
| type: linode_actions.UPDATE_LINODE, | ||
| linode: { id: "foo", state: "booting" } | ||
| }); | ||
| }); | ||
|
|
||
| it('returns linode power shutdown status', async () => { | ||
| await mock_context(async ({ | ||
| auth, dispatch, getState, fetchStub | ||
| }) => { | ||
| const f = powerOffLinode("foo"); | ||
|
|
||
| await f(dispatch, getState); | ||
|
|
||
| sinon.assert.calledWith(fetchStub, | ||
| auth.token, '/linodes/foo/shutdown', { method: "POST" }); | ||
| sinon.assert.calledWith(dispatch, { | ||
| type: linode_actions.UPDATE_LINODE, | ||
| linode: { id: "foo", state: "shutting_down" } | ||
| }); | ||
| }, { | ||
| type: linode_actions.UPDATE_LINODE, | ||
| linode: { id: "foo", state: "shutting_down" } | ||
| }); | ||
| }); | ||
|
|
||
| it('returns linode power reboot status', async () => { | ||
| await mock_context(async ({ | ||
| auth, dispatch, getState, fetchStub | ||
| }) => { | ||
| const f = rebootLinode("foo"); | ||
|
|
||
| await f(dispatch, getState); | ||
|
|
||
| sinon.assert.calledWith(fetchStub, | ||
| auth.token, '/linodes/foo/reboot', { method: "POST" }); | ||
| sinon.assert.calledWith(dispatch, { | ||
| type: linode_actions.UPDATE_LINODE, | ||
| linode: { id: "foo", state: "rebooting" } | ||
| }); | ||
| }, { | ||
| type: linode_actions.UPDATE_LINODE, | ||
| linode: { id: "foo", state: "rebooting" } | ||
| }); | ||
| }); | ||
| })); | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a precedent set earlier but I really don't like this. It would be much more readable if you put this into a variable (called
default_stateor something) and use the variable. Otherwise it's hard to see what this is and what it means. This can be done for each of the three tests.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still can't even tell what it means. I think this is actually the response not the state.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This final argument in the call to mock_context is anonymous. It's hard to know what it is doing there. It would be more readable if you passed a variable to mock_context instead of this anonymous object.