Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upcoming: [M3-7660] - Cleanup files to use profile to get user_type #10102

Merged
merged 9 commits into from
Feb 1, 2024

Conversation

jaalah-akamai
Copy link
Contributor

@jaalah-akamai jaalah-akamai commented Jan 24, 2024

Description 📝

Now that user_type is returned from the /account/profile endpoint, we can save ourselves some query calls.

Changes 🔄

  • Updated tests and files that didn't need to call /account/users/

Preview 📷

Shouldn't be any visual changes

How to test 🧪

Prerequisites

  • Run yarn test ensure all tests pass
  • Run cyrun cypress/e2e/core/account ensure all tests pass

Verification steps

  • Verify user menu still works as intended as with MSW
  • Verify we can see Child Account Access by following steps here

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@jaalah-akamai jaalah-akamai self-assigned this Jan 24, 2024
@jaalah-akamai jaalah-akamai marked this pull request as ready for review January 24, 2024 03:10
@jaalah-akamai jaalah-akamai requested a review from a team as a code owner January 24, 2024 03:10
@jaalah-akamai jaalah-akamai requested review from hana-akamai, cpathipa and mjac0bs and removed request for a team January 24, 2024 03:10
@jaalah-akamai jaalah-akamai changed the title change: [M3-7660] - Cleanup files to use profile to get user_type upcoming: [M3-7660] - Cleanup files to use profile to get user_type Jan 24, 2024
Copy link

github-actions bot commented Jan 24, 2024

Coverage Report:
Base Coverage: 81.13%
Current Coverage: 81.15%

Copy link
Member

@bnussman-akamai bnussman-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more change and should be good to go

….tsx

Co-authored-by: Banks Nussman <115251059+bnussman-akamai@users.noreply.github.com>
@jaalah-akamai
Copy link
Contributor Author

Weird that those don't cause tests to fail 🤔

Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed a fix for ChildAccountList.test.tsx that was not failing when I ran it locally, but was failing in CI. Unit tests are passing as of that last run.

LGTM now. Confirmed that the user menu and Switch Account button (in both menu and Account Landing) is only visible for the expected parent and proxy users. Confirmed that the Child Account Access PAT is visible only for parent users and that there are no regressions when creating a PAT.

@mjac0bs mjac0bs added the Add'tl Approval Needed Waiting on another approval! label Jan 31, 2024
@bnussman-akamai bnussman-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Jan 31, 2024
@jaalah-akamai
Copy link
Contributor Author

✅ Confirmed E2E tests pass with latest develop changes

@jaalah-akamai jaalah-akamai merged commit 6cf8490 into linode:develop Feb 1, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Parent / Child Account
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants