-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upcoming: [M3-7660] - Cleanup files to use profile
to get user_type
#10102
Conversation
profile
to get user_type
profile
to get user_type
Coverage Report: ✅ |
packages/manager/src/features/Account/SwitchAccounts/ChildAccountList.test.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more change and should be good to go
packages/manager/src/features/Account/SwitchAccountDrawer.test.tsx
Outdated
Show resolved
Hide resolved
….tsx Co-authored-by: Banks Nussman <115251059+bnussman-akamai@users.noreply.github.com>
Weird that those don't cause tests to fail 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pushed a fix for ChildAccountList.test.tsx
that was not failing when I ran it locally, but was failing in CI. Unit tests are passing as of that last run.
LGTM now. Confirmed that the user menu and Switch Account button (in both menu and Account Landing) is only visible for the expected parent and proxy users. Confirmed that the Child Account Access PAT is visible only for parent users and that there are no regressions when creating a PAT.
✅ Confirmed E2E tests pass with latest develop changes |
Description 📝
Now that
user_type
is returned from the/account/profile
endpoint, we can save ourselves some query calls.Changes 🔄
/account/users/
Preview 📷
Shouldn't be any visual changes
How to test 🧪
Prerequisites
yarn test
ensure all tests passcyrun cypress/e2e/core/account
ensure all tests passVerification steps
Child Account Access
by following steps hereAs an Author I have considered 🤔
Check all that apply