-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upcoming: [M3-7695] - Add new path_regex
match type to ACLB
#10126
upcoming: [M3-7695] - Add new path_regex
match type to ACLB
#10126
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UI changes look good -- confirmed that the new Path Regex match type is there, Path has been updated to Path Prefix, the tooltips are updated, and tests pass (edit: the CI failure is a VPC test that seem flaky).
More of an API question, but should we be able to actually submit the Path Regex rule? I copied the placeholder text as regex and ended up with Please pass a valid match field
as an error response.
Screen.Recording.2024-01-30.at.2.41.54.PM.mov
Good catch! @mjac0bs I put this up without testing the API. I believe their work for this is still in progress, but I think we can safely test the Cloud Manager pieces and assume the API team will merge their work soon!
This is a great point @carrillo-erik , but that is an issue on the API side. The current response is: {
"reason": "Please pass a valid match field"
} but it really should be {
"field" : "rules[0].match_condition.match_field",
"reason": "Please pass a valid match field"
} |
Going to push a few copy changes required by UX |
query: 'Query String', | ||
}; | ||
|
||
export const matchValuePlaceholder: Record< | ||
CustomerFacingMatchFieldOption, | ||
string | ||
> = { | ||
header: 'x-my-header=this', | ||
header: 'x-my-header:this', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an unrelated change that UX wanted.
Coverage Report: ✅ |
Description 📝
Adds new
path_regex
Rule match type to ACLB. This will allow users to create rules that match on a path using regex.Preview 📷
How to test 🧪
Prerequisites
dev-test-aglb
account for testingVerification steps
aglbsqaMDDA013007
ACLB try to create/edit a rule and choosePath Regex
as the match typeAs an Author I have considered 🤔