Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upcoming: [M3-7695] - Add new path_regex match type to ACLB #10126

Conversation

bnussman-akamai
Copy link
Member

@bnussman-akamai bnussman-akamai commented Jan 30, 2024

Description 📝

Adds new path_regex Rule match type to ACLB. This will allow users to create rules that match on a path using regex.

Preview 📷

Before After
Screenshot 2024-01-30 at 12 48 09 PM Screenshot 2024-01-30 at 12 47 53 PM

How to test 🧪

Prerequisites

  • Check out this PR
  • Switch your Cloud Manager to use the dev environemnt
  • Login to dev-test-aglb account for testing

Verification steps

  • On the aglbsqaMDDA013007 ACLB try to create/edit a rule and choose Path Regex as the match type
  • Verify the copy for tooltips are updated

As an Author I have considered 🤔

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@bnussman-akamai bnussman-akamai added the ACLB Relating to the Akamai Cloud Load Balancer label Jan 30, 2024
@bnussman-akamai bnussman-akamai self-assigned this Jan 30, 2024
@bnussman-akamai bnussman-akamai marked this pull request as ready for review January 30, 2024 20:47
@bnussman-akamai bnussman-akamai requested a review from a team as a code owner January 30, 2024 20:47
@bnussman-akamai bnussman-akamai requested review from carrillo-erik and abailly-akamai and removed request for a team January 30, 2024 20:47
Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI changes look good -- confirmed that the new Path Regex match type is there, Path has been updated to Path Prefix, the tooltips are updated, and tests pass (edit: the CI failure is a VPC test that seem flaky).

More of an API question, but should we be able to actually submit the Path Regex rule? I copied the placeholder text as regex and ended up with Please pass a valid match field as an error response.

Screen.Recording.2024-01-30.at.2.41.54.PM.mov

@mjac0bs mjac0bs added the Add'tl Approval Needed Waiting on another approval! label Jan 30, 2024
@carrillo-erik
Copy link
Contributor

Same observation as Mariah when testing the Path Regex as the type. Also, should the input field show a red outline in addition to the error Notice?

Screenshot 2024-01-30 at 4 00 16 PM

@bnussman-akamai
Copy link
Member Author

bnussman-akamai commented Jan 31, 2024

Good catch! @mjac0bs I put this up without testing the API. I believe their work for this is still in progress, but I think we can safely test the Cloud Manager pieces and assume the API team will merge their work soon!

should the input field show a red outline in addition to the error Notice

This is a great point @carrillo-erik , but that is an issue on the API side. The current response is:

{
  "reason": "Please pass a valid match field"
}

but it really should be

{
  "field" : "rules[0].match_condition.match_field",
  "reason": "Please pass a valid match field"
}

@bnussman-akamai bnussman-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Jan 31, 2024
@bnussman-akamai
Copy link
Member Author

Going to push a few copy changes required by UX

query: 'Query String',
};

export const matchValuePlaceholder: Record<
CustomerFacingMatchFieldOption,
string
> = {
header: 'x-my-header=this',
header: 'x-my-header:this',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an unrelated change that UX wanted.

Copy link

Coverage Report:
Base Coverage: 81.15%
Current Coverage: 81.15%

@bnussman-akamai bnussman-akamai merged commit fa2be99 into linode:develop Jan 31, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ACLB Relating to the Akamai Cloud Load Balancer Approved Multiple approvals and ready to merge!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants