fix: [M3-7722] - Adjust EditableText styling to prevent pixel shift #10132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abailly-akamai
requested review from
carrillo-erik and
jaalah-akamai
and removed request for
a team
|
Coverage Report: ✅ |
carrillo-erik
approved these changes
Jan 31, 2024
|
Simple enough to approve based on the video. |
hkhalil-akamai
approved these changes
Jan 31, 2024
hkhalil-akamai
added
Approved
abailly-akamai
force-pushed
the
M3-7722
branch
from
7ecdab2 to
a146de9
Compare
|
Confirmed test failures are unrelated |
This was referenced Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
This is a tiny PR to fix a small pixel shift when switching on the editable breadcrumb.
Currently, when clicking on the pencil icon to edit the final breadcrumb (title), we can see the whole breadcrumb shift two pixels and make the content underneath shift as well (see before video).
Changes 🔄
Preview 📷
Screen.Recording.2024-01-31.at.10.24.21.mov
Screen.Recording.2024-01-31.at.10.17.01.mov
How to test 🧪
Verification steps
As an Author I have considered 🤔
Check all that apply