Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tech Story: [M3-7360] - DC Get Well - Cleanup/Remove feature flag logic #10146

Merged
merged 2 commits into from
Feb 6, 2024
Merged

Tech Story: [M3-7360] - DC Get Well - Cleanup/Remove feature flag logic #10146

merged 2 commits into from
Feb 6, 2024

Conversation

abailly-akamai
Copy link
Contributor

@abailly-akamai abailly-akamai commented Feb 5, 2024 •
edited
Loading

Description 📝

Small PR to remove the DC Get Well feature flag logic

Changes 🔄

  • Remove FF types
  • Remove FF dev tool entry
  • Remove conditional logic tied to FF

Preview 📷

No visual change is expected as a result of this PR

How to test 🧪

Prerequisites

  • use an account that does not have the no-resource-restriction admin flag

Verification steps

  • Go to the linode create flow (or any other create flow with a RegionSelect)
  • Confirm existing disabled regions (currently Tokyo & Washington DC)

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@abailly-akamai abailly-akamai self-assigned this Feb 5, 2024
@abailly-akamai abailly-akamai changed the title refactor: [M3-7360] - DC Get Well - Cleanup feature flag data refactor: [M3-7360] - DC Get Well - Cleanup/Remove feature flag logic Feb 5, 2024
@abailly-akamai abailly-akamai added the DC Get Well Relating to the DC Get Well project label Feb 5, 2024
@abailly-akamai abailly-akamai marked this pull request as ready for review February 5, 2024 19:46
@abailly-akamai abailly-akamai requested a review from a team as a code owner February 5, 2024 19:46
@abailly-akamai abailly-akamai requested review from cpathipa and jaalah-akamai and removed request for a team February 5, 2024 19:46
@abailly-akamai abailly-akamai changed the title refactor: [M3-7360] - DC Get Well - Cleanup/Remove feature flag logic Tech Story: [M3-7360] - DC Get Well - Cleanup/Remove feature flag logic Feb 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2024

Coverage Report: ✅
Base Coverage: 81.15%
Current Coverage: 81.15%

@abailly-akamai abailly-akamai merged commit b847864 into linode:develop Feb 6, 2024
18 checks passed
@cpathipa cpathipa mentioned this pull request Feb 12, 2024
Closed
This was referenced Feb 20, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpathipa cpathipa cpathipa approved these changes

@bnussman-akamai bnussman-akamai bnussman-akamai approved these changes

@jaalah-akamai jaalah-akamai Awaiting requested review from jaalah-akamai jaalah-akamai is a code owner automatically assigned from linode/frontend

Assignees

@abailly-akamai abailly-akamai

Labels
DC Get Well Relating to the DC Get Well project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abailly-akamai @bnussman-akamai @cpathipa