feat: [OCA-1273] - Add February 2024 Marketplace apps: NATS + Jupyter #10149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…NATS and JupyterLab. updates stackScriptUtils.ts
tbaka-akamai
requested review from
mjac0bs and
carrillo-erik
and removed request for
a team
mjac0bs
changed the title
|
Coverage Report: ✅ |
mjac0bs
reviewed
Feb 6, 2024
There was a problem hiding this comment.
@Tbaka Thanks for the additions. There are a few typos to correct in the code, one of which is causing a typecheck failure. We'll also want to update marketplace.json and add a changeset (via yarn changeset) for our changelog.
|
Please include a |
carrillo-erik
approved these changes
Feb 7, 2024
Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
jdamore-linode
approved these changes
Feb 12, 2024
hana-akamai
approved these changes
Feb 13, 2024
This was referenced Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Contains assets and entries for new OCAs, NATS Single Node and JupyterLab Notebook.
Changes 🔄
List any change relevant to the reviewer.
updates oneClickApps.ts