Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: [M3-7721] - Finish AGLB to ACLB rename #10151

Conversation

bnussman-akamai
Copy link
Member

Description 📝

This PR finishes migrating AGLB (Akamai Global Load Balancer) to ACLB (Akamai Cloud Load Balancer)

Important

This PR will cause Cloud Manager to make fetches to /v4beta/aclb instead of /v4beta/aglb. This should be merged once the API switches over

How to test 🧪

  • The API team must rename the endpoint on their end for this change to work in the dev environment
  • For now, just turn on the MSW and verify http://localhost:3000/loadbalancers/ is working as expected. Calls should be made to /v4beta/aclb instead of /v4beta/aglb
  • Look through the diff and verify I did a good job at finding and replacing all instanced of aglb with aclb

As an Author I have considered 🤔

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@bnussman-akamai bnussman-akamai added Ready for Review ACLB Relating to the Akamai Cloud Load Balancer labels Feb 6, 2024
@bnussman-akamai bnussman-akamai self-assigned this Feb 6, 2024
@bnussman-akamai bnussman-akamai requested review from a team as code owners February 6, 2024 18:54
@bnussman-akamai bnussman-akamai requested review from jdamore-linode, dwiley-akamai and abailly-akamai and removed request for a team February 6, 2024 18:54
Copy link

github-actions bot commented Feb 6, 2024

Coverage Report:
Base Coverage: 81.18%
Current Coverage: 81.18%

Copy link
Contributor

@jdamore-linode jdamore-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice works @bnussman-akamai!

I don't think it matters since I couldn't find "Global Load Balancers" rendered anywhere in the DOM when creating a load balancer, and I don't understand how crumbOverrides work, but does this "Global Load Balancers" need to be replaced in LoadBalancerSummary.tsx?

@bnussman-akamai bnussman-akamai added Add'tl Approval Needed Waiting on another approval! and removed Ready for Review labels Feb 7, 2024
Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aclb

Looks good! - CI failures seem unrelated

@bnussman-akamai bnussman-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Feb 7, 2024
Copy link
Contributor

@dwiley-akamai dwiley-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff review ✅

Searched code base for "AGLB" and variations of "Global Load Balancer", didn't see any instances in code ✅

/loadbalancers works in Cloud and aclb endpoints get called ✅

@bnussman-akamai
Copy link
Member Author

Thank you for the reviews everyone! The plan is to merge this at 2pm EST Monday on Feb 12th

@bnussman-akamai bnussman-akamai merged commit 5aabcf0 into linode:develop Feb 12, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ACLB Relating to the Akamai Cloud Load Balancer Approved Multiple approvals and ready to merge!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants