-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change: [M3-7721] - Finish AGLB
to ACLB
rename
#10151
change: [M3-7721] - Finish AGLB
to ACLB
rename
#10151
Conversation
Coverage Report: ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice works @bnussman-akamai!
I don't think it matters since I couldn't find "Global Load Balancers" rendered anywhere in the DOM when creating a load balancer, and I don't understand how crumbOverrides
work, but does this "Global Load Balancers" need to be replaced in LoadBalancerSummary.tsx
?
Line 35 in 093715b
label: 'Global Load Balancers', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Diff review ✅
Searched code base for "AGLB" and variations of "Global Load Balancer", didn't see any instances in code ✅
/loadbalancers
works in Cloud and aclb
endpoints get called ✅
Thank you for the reviews everyone! The plan is to merge this at 2pm EST Monday on Feb 12th |
Description 📝
This PR finishes migrating AGLB (Akamai Global Load Balancer) to ACLB (Akamai Cloud Load Balancer)
Important
This PR will cause Cloud Manager to make fetches to
/v4beta/aclb
instead of/v4beta/aglb
. This should be merged once the API switches overHow to test 🧪
/v4beta/aclb
instead of/v4beta/aglb
aglb
withaclb
As an Author I have considered 🤔