fix: [M3-7739] - Fix error when enabling backups for Linodes in regions with $0 price #10153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdamore-linode
requested review from
mjac0bs and
carrillo-erik
and removed request for
a team
jdamore-linode
commented
Feb 6, 2024
Comment on lines
+50
to
+51
| const hasBackupsMonthlyPriceError = | ||
| !backupsMonthlyPrice && backupsMonthlyPrice !== 0; |
There was a problem hiding this comment.
Wasn't 100% sure what the clearest way to express this is
Opted for this since it telegraphs that 0 is a valid value, but if something else would be clearer to the team, like checking explicitly for null or undefined, I'm happy to tweak this.
…ions with /bin/sh pricing
|
Coverage Report: ❌ |
mjac0bs
approved these changes
Feb 7, 2024
Comment on lines
+50
to
+51
| const hasBackupsMonthlyPriceError = | ||
| !backupsMonthlyPrice && backupsMonthlyPrice !== 0; |
Shakes fist |
Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
jaalah-akamai
approved these changes
Feb 9, 2024
jaalah-akamai
added
Approved
jdamore-linode
added a commit
to jdamore-linode/manager
that referenced
this pull request
Feb 12, 2024
…ns with $0 price (linode#10153) * Fix error when enabling backups for Linodes in regions with $0 price * Add unit tests for EnableBackupsDialog --------- Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
12 tasks
jdamore-linode
added a commit
that referenced
this pull request
Feb 12, 2024
…xes for release (#10177) * fix: [M3-7741] - Hide error notices for $0 regions in Resize Pool and Add a Node Pool drawers (#10157) * Allow -zsh LKE prices without error notices in Resize Pool and Add Pool drawers * Fix loading spinner displaying above what was supposed to be loading * Fix conditional to render notice if either price is invalid * Add test coverage * Added changeset: Hide error notices for /bin/sh regions for LKE Resize and Add Node Pools * Fix changeset wording * Address feedback: use invalid price util * fix: [M3-7746] - Fix $0 region price error in "Enable All Backups" drawer (#10161) * Remove error indicator for Linodes in $0 regions * Fix $0 total price display issue * Cover $0 pricing cases in Cypress backup tests * Add BackupLinodeRow tests to account for error states and $0 regions * Add unit tests for BackupDrawer component * fix: [M3-7747] - Fix Linode Migration dialog hidden $0 price (#10166) * Add unit tests for MigrationPricing component * Accounting for $0 prices in MigrationPricing component * fix: [M3-7739] - Fix error when enabling backups for Linodes in regions with $0 price (#10153) * Fix error when enabling backups for Linodes in regions with $0 price * Add unit tests for EnableBackupsDialog --------- Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com> * Replace "toBeDisabled" with "toHaveAttribute" assertion --------- Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
This was referenced Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
This fixes an error message that appears when enabling Linode backups in regions with $0 prices.
Changes 🔄
nullorundefined, but allow0How to test 🧪
Automated Tests
Serve Cloud with
yarn && yarn build && yarn start:manager:ci, and then:(Note: This will only work on accounts that have access to the
es-madregion, and won't be properly validated by our CI)Manual
es-madregion(Edit: You can also test that the error message still appears when expected by blocking the request to the
/linode/types/:typeendpoint via Chrome's dev tools)Reproduction steps
You can reproduce the error with the tests if
developis checked out.yarn && yarn build && yarn start:manager:ci, and then:(Note: This will only work on accounts that have access to the
es-madregion)Similarly, you can follow the steps above to reproduce the issue manually.
As an Author I have considered 🤔
Check all that apply