-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upcoming: [M3-7615] - Add placement group to payload #10195
Conversation
packages/manager/src/components/LabelAndTagsPanel/LabelAndTagsPanel.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/Linodes/LinodesCreate/LinodeCreateContainer.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/Linodes/LinodesCreate/LinodeCreateContainer.tsx
Show resolved
Hide resolved
packages/manager/src/features/Linodes/LinodesCreate/LinodeCreate.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR looks and UI look good, however we still need some changes
-
The placement_group payload is still sent when the flag is OFF, which we want to avoid
-
the validation does not seem to work properly, I was able to send a POST with just the strict value?
4, left some comments to change the strict boolean in the payload
Coverage Report: ✅ |
@abailly-akamai |
@carrillo-erik it should be undefined, because this key does not exist in the upstream schema |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need a changeset for APIv4?
@carrillo-erik When the error appears the tooltip icon shifts down. We should remove the tooltip icon here and just pass
Obviously when you call the underlying |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates! Approving pending change suggested by @jaalah-akamai
Description 📝
The main concept with this PR is to include the details of the selected
Placement Group
as part of theCreate Linode
workflow.Changes 🔄
List any change relevant to the reviewer.
LabelAndTagsPanel
has been renamed toDetailsPanel
since the panel had been updated to include thePlacementGroupSelect
component. Accordingly, theDetails
title has been added to the panel.PlacementGroup
does not have any capacity, an errorNotice
is displayed within the panel.Placement Group
details.Preview 📷
How to test 🧪
(How to setup test environment)
Verification steps
Success
Create Linode
workflow and selectNewark, NJ (us-east)
for theRegion
.Placement Groups
.Create Linode
button.Error
placementGroupFactory
by adding an additional element to thelinode_ids
array. This will make thePlacement Group
be at full capacity.Create Linode
workflow as above.Create Linode
button results in an error and theNotice
is displayed.As an Author I have considered 🤔
Check all that apply