-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upcoming: [M3-7798] - Update Buckets landing page to use regions instead of clusters. #10244
Conversation
Coverage Report: ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was looking good from my testing, though typecheck is currently failing:
-
Validated buckets landing is fetched with regions instead of clusters (e.g. GET
object-storage/buckets/us-iad?page_size=500
)
Note: I'm not very familiar with the Object-MultiCluster feature or the mock data, but in addition to the GET requests for buckets that use regions, I was also seeing requests that include the cluster. Wasn't certain if that was still expected.
-
Validated bucket access is fetched (endpoint) with regions instead of clusters (e.g. GET
object-storage/buckets/us-iad/obj-bucket-1/access
) -
Verified the bucket access PUT request has updated with region instead of clusters (e.g. PUT
object-storage/buckets/us-iad/obj-bucket-1/access
) -
With the feature flag off, tested Buckets landing and Details CRUD flows for regressions
packages/manager/.changeset/pr-10244-upcoming-features-1709333927883.md
Outdated
Show resolved
Hide resolved
packages/manager/src/features/ObjectStorage/BucketLanding/BucketTableRow.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/ObjectStorage/BucketLanding/BucketTableRow.tsx
Outdated
Show resolved
Hide resolved
I was able to verify that the buckets are fetched with regions instead of clusters and that bucket access is fetched with regions endpoint instead of clusters. Functionality appears to be working as expected. One minor visual regression I noticed is with the carat (^) symbol in the dropdown menu. In other places in the app, when the user engages with the dropdown the carat symbol is inverted and the color changes from gray to blue, denoting it's active. That is not the case with this PR, please take a look at the photos below. Current Behavior:Expected Behavior: |
…927883.md Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
…etTableRow.tsx Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
@carrillo-erik Good find. It looks like the same behavior is present in production as well, not introduced by this PR. I'm not sure what's causing this issue. Considering the scope of this ticket, I've created a separate bug ticket (M3-7864) to address this issue. |
@mjac0bs Thank you for the thorough testing.
|
Looking into the failed object-storage.smoke.spec test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing the feedback! Confirmed that other than the test failure, this all looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just want to call out an issue with the recent change to the e2e file before it gets merged! Happy to help work out this test issue
packages/manager/cypress/e2e/core/objectStorage/object-storage.smoke.spec.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @cpathipa, looks good!
Description 📝
Update Buckets landing page to use regions instead of clusters.
Prerequisites
(How to setup test environment)
Verification steps
(How to verify changes)
Buckets Landing page:
Bucket Details Drawer:
Details
action button and validate bucket access is fetched (endpoint) with regions instead of clusters.Turn off feature flag and MSW.
As an Author I have considered 🤔
Check all that apply