upcoming: [M3-7857] - Account Management Copy Updates & Improvements #10270

jaalah-akamai · 2024-03-11T15:34:53Z

Description 📝

This PR addresses some updating messaging and account management fixes / improvements.

Changes 🔄

Update Proxy Account Closure Tooltip (Proxy User):
- When attempting to close an account as a proxy user, the tooltip should now read: "Contact customer support to close this account."
Clarify Account Closure Instructions (Parent User):
- Change the tooltip text from "Remove indirect customers before closing the account." to "Remove child accounts before closing the account."
Update Account Login Indicator (General):
- Modify the account indicator text from "You are currently logged in as:" to "Current account:"
New PAT Tooltip for Proxy View (Proxy User):
- For proxy users, introduce a new tooltip for disabled Personal Access Tokens (PAT) creation with the text: "You can't perform this action on child accounts."
Fix Billing Contact Info Bug (Parent User):
- Address the bug preventing parent users from updating billing contact information due to the company field not being omitted from the payload.
Limit Proxy Account Login Toast (Proxy User):
- Ensure the login toast for proxy accounts only appears once per session by utilizing local storage to manage its visibility.

Target release date 🗓️

3/18

Preview 📷

Before	After

	Now you can update contact information!

How to test 🧪

Prerequisites

(How to setup test environment)

Update parent to proxy in [MSW] (https://github.com/linode/manager/blob/develop/packages/manager/src/mocks/serverHandlers.ts#L558) when needed.
or use your Parent/Child accounts

Verification steps

Verify changes above...

As an Author I have considered 🤔

Check all that apply

…vements

jaalah-akamai · 2024-03-11T15:39:04Z

packages/manager/src/features/Profile/APITokens/APITokenTable.tsx

-                isProxyUser
-                  ? 'You can only create tokens for your own company.'
-                  : undefined
+            <Button


Changed this to a Button in order to show the tooltip icon for the disabled state. AddNewLink should probably be deprecated in the future.

github-actions · 2024-03-11T15:58:54Z

Coverage Report: ✅
Base Coverage: 81.39%
Current Coverage: 81.39%

jdamore-linode

Looks good, thanks @jaalah-akamai! Approved pending update for wording in personal-access-tokens.spec.ts here:

manager/packages/manager/cypress/e2e/core/account/personal-access-tokens.spec.ts

Line 279 in 882c435

.findByText('You can only create tokens for your own company.')

Edit: And maybe line 295 too

dwiley-akamai

Update Proxy Account Tooltip (Proxy User):
- When attempting to close an account as a proxy user, the tooltip should now read: "Contact customer support to close this account." ✅
Clarify Account Closure Instructions (Proxy User):
- Change the tooltip text from "Remove indirect customers before closing the account." to "Remove child accounts before closing the account."
- Testing this with the mocks seemed inconsistent/tricky. When I first turned the MSW on and changed L558 to proxy, I saw this tooltip text, and continued to see it after commenting out L1364. Then I circled back after testing a few other things, and saw the "Contact customer support to close this account." text although there was a child user on the Users & Grants page. Then with L558 set to parent and L1364 commented out, I see this text although childAccountUser isn't getting returned in the response to */account/users'
Update Account Login Indicator (General):
- Modify the account indicator text from "You are currently logged in as:" to "Current account:" ✅
New PAT Tooltip for Proxy View (Proxy User):
- For proxy users, introduce a new tooltip for disabled Personal Access Tokens (PAT) creation with the text: "You can’t create access tokens for child accounts. Instead, switch to your account and create the token there." ✅
Fix Billing Contact Info Bug (Parent User):
- Address the bug preventing parent users from updating billing contact information due to the company field not being omitted from the payload. ✅
Limit Proxy Account Login Toast (Proxy User):
- Ensure the login toast for proxy accounts only appears once per session by utilizing local storage to manage its visibility.
- If this can be tested with the MSW, are there any precise steps to take?

The User Settings table looks like it needs some attention for Proxy users:

jaalah-akamai · 2024-03-11T20:26:59Z

@dwiley-akamai We'll look into updating MSW, since it's not always a perfect reflection of the feature.

mjac0bs

Confirmed:

✅ Copy update to PAT button as proxy user
✅ Copy updates for Close Account buttons depending on user type
✅ Only saw the toast once and see the local storage value set - I just think we should document what we're doing here
✅ Can edit a parent account's billing contact info without error
✅ Copy update to user menu

Approving pending test updates and some minor nitpicks/comments.

@dwiley-akamai - to your point about the proxy user row: Thanks for checking on that, it is one case where the mocks don't reflect the feature. The proxy user will never appear in the general users table. Instead, it lives in its own table above the users table and is visible to child users and unrestricted proxy users. Table column count should be correct in that case, but not when it's currently mocked in the users table since we are not displaying some cols for the proxy user.

packages/manager/src/features/Account/SwitchAccountDrawer.tsx

packages/manager/src/features/TopMenu/UserMenu/UserMenu.tsx

mjac0bs · 2024-03-11T20:37:31Z

packages/manager/src/features/TopMenu/UserMenu/UserMenu.tsx

@@ -270,7 +272,7 @@ export const UserMenu = React.memo(() => {
      >
        <Stack data-qa-user-menu minWidth={250} spacing={2}>
          {canSwitchBetweenParentOrProxyAccount && (
-            <Typography>You are currently logged in as:</Typography>
+            <Typography>Current account:</Typography>


For posterity: this was an ask by UX, so it's an update to stay true to the mocks. It does feel a bit different from other Cloud Manager helper text in language/tone. (To me, "Current user" seems like a console statement just printed to the screen 😅.) Perhaps we can revisit in the future with feedback from stakeholders (Product, resellers).

mjac0bs · 2024-03-11T20:44:33Z

packages/manager/src/features/Account/CloseAccountSetting.tsx

+  const caseKey = isCloseAccountDisabled ? userType : 'default';
+
+  switch (caseKey) {


Slightly unfortunate to also have a user_type named "default" when the default case of the switch is for the parent user. Wondering if this will be a cause for confusion in the future.

packages/manager/src/MainContent.tsx

packages/manager/src/features/Account/constants.ts

packages/manager/cypress/e2e/core/account/personal-access-tokens.spec.ts

hkhalil-akamai

Verified all copy changes. One change is different from the PR description.

Testing via MSW, to unable to verify bug fixes to Billing Contact Info and Login Toast.

hkhalil-akamai · 2024-03-12T15:52:26Z

packages/manager/src/features/Profile/APITokens/APITokenTable.tsx

-                  : undefined
+            <Button
+              tooltipText={
+                isProxyUser ? PROXY_USER_RESTRICTED_TOOLTIP_TEXT : undefined


This tooltip now reads "You can't perform this action on child accounts." instead of "You can’t create access tokens for child accounts. Instead, switch to your account and create the token there." -- just verifying this is an intentional change.

Yes - let me update PR 👍

upcoming: [M3-7857] - Account Management Copy/Updates

4083fce

jaalah-akamai added the Parent / Child Account label Mar 11, 2024

jaalah-akamai self-assigned this Mar 11, 2024

jaalah-akamai requested a review from a team as a code owner March 11, 2024 15:34

jaalah-akamai requested review from dwiley-akamai, hkhalil-akamai, jdamore-linode and mjac0bs and removed request for a team March 11, 2024 15:34

Added changeset: Parent/Child Account Management Copy Updates & Impro…

d46ca3b

…vements

jaalah-akamai changed the title ~~upcoming: [M3-7857] - Account Management Copy/Updates~~ upcoming: [M3-7857] - Account Management Copy Updates & Improvements Mar 11, 2024

Fix merge conflict

882c435

jaalah-akamai commented Mar 11, 2024

View reviewed changes

mjac0bs added the Bug Fixes for regressions or bugs label Mar 11, 2024

jdamore-linode approved these changes Mar 11, 2024

View reviewed changes

dwiley-akamai reviewed Mar 11, 2024

View reviewed changes

mjac0bs approved these changes Mar 11, 2024

View reviewed changes

Update to latest copy - combined some constants - updated tests

3b2e2b7

jaalah-akamai requested a review from a team as a code owner March 12, 2024 14:51

jaalah-akamai requested review from cliu-akamai and removed request for a team March 12, 2024 14:51

jaalah-akamai commented Mar 12, 2024

View reviewed changes

packages/manager/cypress/e2e/core/account/personal-access-tokens.spec.ts Show resolved Hide resolved

Update to smart quote

d0bd01b

hkhalil-akamai approved these changes Mar 12, 2024

View reviewed changes

jaalah-akamai merged commit 74695aa into linode:develop Mar 12, 2024
17 of 18 checks passed

This was referenced Mar 18, 2024

Release v1.115.0 - release → staging #10292

Merged

Release v1.115.0 - staging → master #10293

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

upcoming: [M3-7857] - Account Management Copy Updates & Improvements #10270

upcoming: [M3-7857] - Account Management Copy Updates & Improvements #10270

jaalah-akamai commented Mar 11, 2024 •

edited by mjac0bs

Loading

jaalah-akamai Mar 11, 2024

github-actions bot commented Mar 11, 2024 •

edited

Loading

jdamore-linode left a comment •

edited

Loading

dwiley-akamai left a comment

jaalah-akamai commented Mar 11, 2024

mjac0bs left a comment

mjac0bs Mar 11, 2024 •

edited

Loading

mjac0bs Mar 11, 2024

hkhalil-akamai left a comment

hkhalil-akamai Mar 12, 2024

jaalah-akamai Mar 12, 2024

		const caseKey = isCloseAccountDisabled ? userType : 'default';

		switch (caseKey) {

upcoming: [M3-7857] - Account Management Copy Updates & Improvements #10270

upcoming: [M3-7857] - Account Management Copy Updates & Improvements #10270

Conversation

jaalah-akamai commented Mar 11, 2024 • edited by mjac0bs Loading

Description 📝

Changes 🔄

Target release date 🗓️

Preview 📷

How to test 🧪

Prerequisites

Verification steps

As an Author I have considered 🤔

jaalah-akamai Mar 11, 2024

Choose a reason for hiding this comment

github-actions bot commented Mar 11, 2024 • edited Loading

jdamore-linode left a comment • edited Loading

Choose a reason for hiding this comment

dwiley-akamai left a comment

Choose a reason for hiding this comment

jaalah-akamai commented Mar 11, 2024

mjac0bs left a comment

Choose a reason for hiding this comment

mjac0bs Mar 11, 2024 • edited Loading

Choose a reason for hiding this comment

mjac0bs Mar 11, 2024

Choose a reason for hiding this comment

hkhalil-akamai left a comment

Choose a reason for hiding this comment

hkhalil-akamai Mar 12, 2024

Choose a reason for hiding this comment

jaalah-akamai Mar 12, 2024

Choose a reason for hiding this comment

jaalah-akamai commented Mar 11, 2024 •

edited by mjac0bs

Loading

github-actions bot commented Mar 11, 2024 •

edited

Loading

jdamore-linode left a comment •

edited

Loading

mjac0bs Mar 11, 2024 •

edited

Loading