Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [M3-7867] -Ensure IP / Mask for firewall rules drawer correctly populates #10279

Merged
merged 4 commits into from
Mar 13, 2024

Conversation

jaalah-akamai
Copy link
Contributor

@jaalah-akamai jaalah-akamai commented Mar 13, 2024

Description 📝

There was an issue where on first page load where the IP / Netmask input fields weren't populating properly when you first open the firewall rules drawer.

Changes 🔄

  • Remove the autoFocus which we don't need. We could technically keep this, but just seemed odd that we wanted to focus those fields apart from all the other relevant fields.
  • Root issue was we're overriding our IPs when an input is blurred. I added a check to ensure the value is not empty before we attempt to call onBlur and set our state

Target release date 🗓️

3/18

Preview 📷

Before After
wrong.mp4
right.mp4

Initial / Secondary Render
Screenshot 2024-03-13 at 3 08 27 PM

How to test 🧪

Prerequisites

  • Create an inbound firewall rule with two IP/Netmasks

Reproduction steps

  • Reload the page
  • Open firewall rules drawer
  • Observer bug

Verification steps

  • Checkout branch
  • Reload page
  • Open firewall rules drawer
  • Observe fix

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@jaalah-akamai jaalah-akamai requested a review from a team as a code owner March 13, 2024 19:32
@jaalah-akamai jaalah-akamai requested review from cpathipa and hkhalil-akamai and removed request for a team March 13, 2024 19:32
@jaalah-akamai jaalah-akamai self-assigned this Mar 13, 2024
@jaalah-akamai jaalah-akamai added the Bug Fixes for regressions or bugs label Mar 13, 2024
Copy link

github-actions bot commented Mar 13, 2024

Coverage Report:
Base Coverage: 81.39%
Current Coverage: 81.39%

Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix - Please add a changeset and let's get this in the release

Copy link
Member

@bnussman-akamai bnussman-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IPs are populating as expected! Thanks for working on this fix!

@jaalah-akamai jaalah-akamai changed the title fix: [M3-7867] - Ensure IP input field receives latest state data fix: [M3-7867] -Ensure IP / Mask for firewall rules drawer correctly populates Mar 13, 2024
@mjac0bs mjac0bs added the Approved Multiple approvals and ready to merge! label Mar 13, 2024
@jaalah-akamai jaalah-akamai merged commit b59e794 into linode:develop Mar 13, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Bug Fixes for regressions or bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants