upcoming: [M3-7536] - Disable fetching buckets with clusters when ObjMultiClusterEnabled flag is enabled. #10282

cpathipa · 2024-03-14T13:18:42Z

Description 📝

Disables fetching buckets with clusters when ObjMultiClusterEnabled flag is enabled across the CM.

Target release date 🗓️

04/20

How to test 🧪

Prerequisites

(How to setup test environment)

Turn on ObjMultiCluster flag and MSW

Verification steps

Turn on the ObjMultiCluster flag and MSW

Navigate the http://localhost:3000/object-storage/buckets
Ensure no network calls fired to fetch buckets with clusters.
Verify the buckets flow. Ensure all buckets flow (Access, SSL/TLS, upload etc.) endpoints should use region instead of cluster.
Verify the Access flow. Ensure all access flow endpoints should use region instead of cluster.

Turn off the ObjMultiCluster flag and MSW

Verify there is no regression in whole OBJ flow.
Verify there is no regression in SearchBar, SearchLanding and PrimaryNav usage.

As an Author I have considered 🤔

Check all that apply

…bjMultiClusterEnabled flag is enabled.

…ClusterEnabled flag is enabled.

github-actions · 2024-03-14T13:40:04Z

Coverage Report: ✅
Base Coverage: 81.69%
Current Coverage: 81.71%

dwiley-akamai

ObjMultiCluster flag + MSW on:

No network calls fired with clusters to fetch buckets ✅
Buckets and Access flows use region instead of cluster ✅

ObjMultiCluster flag and MSW off:

No regressions observed in OBJ flow ✅

Compared to develop or even this branch with the feature flag off, when I have the feature flag on and try to navigate to the Search landing page, I get an infinite spinner.

packages/manager/src/components/PrimaryNav/PrimaryNav.tsx

packages/manager/src/queries/objectStorage.ts

mjac0bs

Approving pending Dajahi's feedback is addressed, merge conflicts are resolved, and no one else can replicate the loading issue with the search.

With the feature flag and MSW:

Ensured no network calls fired to fetch buckets with clusters*.
Verified the buckets flow. Ensure all buckets flow (Access, SSL/TLS, upload etc.) endpoints should use region instead of cluster.
Verified the Access flow. Ensure all access flow endpoints should use region instead of cluster.

Without the feature flag and mocks:

Verified there is no regression in whole OBJ flow.
Verify there is no regression in SearchBar, SearchLanding and PrimaryNav usage.

Compared to develop or even this branch with the feature flag off, when I have the feature flag on and try to navigate to the Search landing page, I get an infinite spinner.

@dwiley-akamai - I couldn't replicate this. Are you still seeing it, and did mean something other than either of the searches I show in this video? This was on this branch with feature flag and mocks off.

Screen.Recording.2024-03-21.at.10.30.17.AM.mov

*One other question b/c I'm not fully familiar with the OMC work: I see we're still fetching the list of object storage clusters on the OBJ landing page, but (as intended) not using clusters for buckets. Do we still need to fetch these all clusters for this feature?

packages/manager/.changeset/pr-10282-upcoming-features-1710422378958.md

…378958.md Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>

… enabled in buckets landing page.

cpathipa · 2024-03-25T23:19:06Z

@mjac0bs Addressed fetching clusters when OMC flag is enabled 44791f3.

…rs file.

carrillo-erik · 2024-03-26T17:34:30Z

packages/manager/src/utilities/types/typesHelpers.ts

+};
+
+// Utility type to enforce at least one of `clusters` or `regions` to be provided.
+export type AtLeastOne<T, U = { [K in keyof T]: Pick<T, K> }> = Partial<T> &


The name of this type feels a little weird to me, sounds like a boolean variable name.

carrillo-erik · 2024-03-26T17:42:11Z

@cpathipa Looks good to me, only one small nitpick with the naming for the AtLeastOne type.

dwiley-akamai · 2024-03-26T20:44:27Z

@dwiley-akamai - I couldn't replicate this. Are you still seeing it, and did mean something other than either of the searches I show in this video? This was on this branch with feature flag and mocks off.

Screen.Recording.2024-03-21.at.10.30.17.AM.mov

@mjac0bs I may have worded it confusingly last time, but I'm observing that behavior when the feature flag is on and mocks off. (for the example below, the account has multiple buckets with "iad" in their names)

Screen.Recording.2024-03-26.at.4.29.59.PM.mov

It shouldn't be an issue when the API is functional, but right now I think useObjectStorageBuckets in SearchLanding.tsx stalls out and areBucketsLoading stays false.

dwiley-akamai

Going ahead and approving since the core of the ticket is complete

packages/manager/src/features/Search/SearchLanding.tsx

cpathipa · 2024-03-27T15:48:52Z

@dwiley-akamai I see what you meant. Handled the fetching of buckets with regions from the search landing page more gracefully when the obj flag is on and MSW is off.

SearchLandingPage.mov

@mjac0bs

…MultiClusterEnabled flag is enabled. (linode#10282) * upcoming: [M3-7536] - Disable fetching buckets with clusters when isObjMultiClusterEnabled flag is enabled. * Added changeset: Disable fetching buckets with clusters when ObjMultiClusterEnabled flag is enabled. * code cleanup * Update packages/manager/.changeset/pr-10282-upcoming-features-1710422378958.md Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com> * Update regions imports. * PR - feedback - @mjac0bs - disable fetching clusters when OMC flag is enabled in buckets landing page. * PR -feedback - @DevDW - naming convention regionsSupportingObjectStorage * Organize typeHelpers util and moved AtLeastOne util type to typeHelpers file. * Update SearchLanding.tsx --------- Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>

upcoming: [M3-7536] - Disable fetching buckets with clusters when isO…

00b2f53

…bjMultiClusterEnabled flag is enabled.

cpathipa requested a review from a team as a code owner March 14, 2024 13:18

cpathipa requested review from carrillo-erik and jaalah-akamai and removed request for a team March 14, 2024 13:18

cpathipa self-assigned this Mar 14, 2024

cpathipa marked this pull request as draft March 14, 2024 13:18

cpathipa added the OBJ Multi-Cluster label Mar 14, 2024

Added changeset: Disable fetching buckets with clusters when ObjMulti…

26eb3c5

…ClusterEnabled flag is enabled.

cpathipa marked this pull request as ready for review March 14, 2024 13:29

cpathipa requested review from dwiley-akamai and mjac0bs March 14, 2024 13:30

code cleanup

1e4eb36

dwiley-akamai reviewed Mar 19, 2024

View reviewed changes

packages/manager/src/components/PrimaryNav/PrimaryNav.tsx Outdated Show resolved Hide resolved

packages/manager/src/queries/objectStorage.ts Outdated Show resolved Hide resolved

mjac0bs approved these changes Mar 21, 2024

View reviewed changes

packages/manager/.changeset/pr-10282-upcoming-features-1710422378958.md Outdated Show resolved Hide resolved

cpathipa and others added 4 commits March 25, 2024 17:25

Update packages/manager/.changeset/pr-10282-upcoming-features-1710422…

f4f49f7

…378958.md Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>

Merge remote-tracking branch 'origin/develop' into M3-7536

f24a527

Update regions imports.

bbee941

PR - feedback - @mjac0bs - disable fetching clusters when OMC flag is…

44791f3

… enabled in buckets landing page.

cpathipa added 2 commits March 25, 2024 18:22

PR -feedback - @DevDW - naming convention regionsSupportingObjectStorage

ba9cbdb

Organize typeHelpers util and moved AtLeastOne util type to typeHelpe…

bde6b79

…rs file.

cpathipa requested a review from dwiley-akamai March 25, 2024 23:44

cpathipa added the Add'tl Approval Needed Waiting on another approval! label Mar 25, 2024

bnussman-akamai approved these changes Mar 26, 2024

View reviewed changes

bnussman-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Mar 26, 2024

carrillo-erik reviewed Mar 26, 2024

View reviewed changes

carrillo-erik approved these changes Mar 26, 2024

View reviewed changes

dwiley-akamai approved these changes Mar 26, 2024

View reviewed changes

packages/manager/src/features/Search/SearchLanding.tsx Outdated Show resolved Hide resolved

Update SearchLanding.tsx

0f3764c

cpathipa merged commit 98b5dbf into linode:develop Mar 29, 2024
18 checks passed

This was referenced Apr 11, 2024

Release v1.117.0 - release → staging #10368

Merged

Release v1.117.0 - staging → master #10377

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

upcoming: [M3-7536] - Disable fetching buckets with clusters when ObjMultiClusterEnabled flag is enabled. #10282

upcoming: [M3-7536] - Disable fetching buckets with clusters when ObjMultiClusterEnabled flag is enabled. #10282

cpathipa commented Mar 14, 2024 •

edited

Loading

github-actions bot commented Mar 14, 2024 •

edited

Loading

dwiley-akamai left a comment

mjac0bs left a comment •

edited

Loading

cpathipa commented Mar 25, 2024

carrillo-erik Mar 26, 2024

carrillo-erik commented Mar 26, 2024

dwiley-akamai commented Mar 26, 2024 •

edited

Loading

dwiley-akamai left a comment

cpathipa commented Mar 27, 2024 •

edited

Loading

upcoming: [M3-7536] - Disable fetching buckets with clusters when ObjMultiClusterEnabled flag is enabled. #10282

upcoming: [M3-7536] - Disable fetching buckets with clusters when ObjMultiClusterEnabled flag is enabled. #10282

Conversation

cpathipa commented Mar 14, 2024 • edited Loading

Description 📝

Target release date 🗓️

How to test 🧪

Prerequisites

Verification steps

Turn on the ObjMultiCluster flag and MSW

Turn off the ObjMultiCluster flag and MSW

As an Author I have considered 🤔

github-actions bot commented Mar 14, 2024 • edited Loading

dwiley-akamai left a comment

Choose a reason for hiding this comment

mjac0bs left a comment • edited Loading

Choose a reason for hiding this comment

cpathipa commented Mar 25, 2024

carrillo-erik Mar 26, 2024

Choose a reason for hiding this comment

carrillo-erik commented Mar 26, 2024

dwiley-akamai commented Mar 26, 2024 • edited Loading

dwiley-akamai left a comment

Choose a reason for hiding this comment

cpathipa commented Mar 27, 2024 • edited Loading

cpathipa commented Mar 14, 2024 •

edited

Loading

github-actions bot commented Mar 14, 2024 •

edited

Loading

mjac0bs left a comment •

edited

Loading

dwiley-akamai commented Mar 26, 2024 •

edited

Loading

cpathipa commented Mar 27, 2024 •

edited

Loading