upcoming: [M3-7938] - Show custom error message in EditAccessKeyDrawer #10329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpathipa
requested review from
dwiley-akamai and
abailly-akamai
and removed request for
a team
cpathipa
commented
Mar 29, 2024
|
Coverage Report: ✅ |
packages/manager/.changeset/pr-10329-upcoming-features-1711724710965.md
Outdated
Show resolved
Hide resolved
packages/manager/src/features/ObjectStorage/AccessKeyLanding/OMC_AccessKeyDrawer.tsx
Outdated
Show resolved
Hide resolved
…710965.md Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com>
mjac0bs
approved these changes
Mar 29, 2024
There was a problem hiding this comment.
Thanks Chandra!
I'm not entirely sure how helpful the link out to the landing page is for "revoke" since we don't link directly to the revoke modal via URL path, and the action menu is collapsed so the user can't actually see "Revoke" unless they open it. That being said, it does indicate to the user that they need to go somewhere that is not the edit drawer, which could set them on the right path, so the link may have some benefit.
...es/manager/src/features/ObjectStorage/AccessKeyLanding/AccessKeyRegions/AccessKeyRegions.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/ObjectStorage/AccessKeyLanding/OMC_AccessKeyDrawer.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/ObjectStorage/AccessKeyLanding/OMC_AccessKeyDrawer.tsx
Outdated
Show resolved
Hide resolved
|
@mjac0bs @abailly-akamai - Removed the link and updated the error message copy as approved by UX. |
abailly-akamai
approved these changes
Apr 2, 2024
|
Copy looks good! Thanks for updating the PR description screenshot too. 🚢 |
bnussman-akamai
pushed a commit
to bnussman-akamai/manager
that referenced
this pull request
Apr 4, 2024
linode#10329) * upcoming: [M3-7938] - Show custom error message in EditAccessKeyDrawer * Added changeset: Show custom error message in EditAccessKeyDrawer. * Update packages/manager/.changeset/pr-10329-upcoming-features-1711724710965.md Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com> * PR feedback - @DevDW @mjac0bs * PR - feedback - @alioso * UX - Change - update error message. * Update pr-10329-upcoming-features-1711724710965.md --------- Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com>
This was referenced Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Renders custom error message in EditAccessKeyDrawer.
Changes 🔄
List any change relevant to the reviewer.
Preview 📷
How to test 🧪
Prerequisites
(How to setup test environment)
Verification steps
(How to verify changes)
As an Author I have considered 🤔
Check all that apply