Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [M3-7953] - Reset SSH key form on cancel and close #10344

Merged
merged 2 commits into from
Apr 3, 2024
Merged

fix: [M3-7953] - Reset SSH key form on cancel and close #10344

merged 2 commits into from
Apr 3, 2024

Conversation

jdamore-linode
Copy link
Contributor

Description 📝

Fixes a small issue where the "Add an SSH Key" form doesn't reset when clicking the drawer's close or cancel buttons.

Changes 🔄

  • Resets formik state when clicking the drawer's close and cancel buttons

How to test 🧪

  • Confirm form resets as expected via Profile page at /profile/keys
  • Confirm form resets as expected via Linode create flow
  • Confirm SSH keys can still be added via Profile page at /profile/keys
  • Confirm SSH keys can still be added via Linode create flow

@jdamore-linode jdamore-linode self-assigned this Apr 2, 2024
@jdamore-linode jdamore-linode requested a review from a team as a code owner April 2, 2024 20:29
@jdamore-linode jdamore-linode requested review from mjac0bs and hana-akamai and removed request for a team April 2, 2024 20:29
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 2, 2024 •
edited
Loading

Coverage Report: ✅
Base Coverage: 81.72%
Current Coverage: 81.72%

mjac0bs
mjac0bs approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching!

✅ Form resets as expected via Profile page at /profile/keys
✅ Form resets as expected via Linode create flow
✅ SSH keys can still be added via Profile page at /profile/keys
✅ SSH keys can still be added via Linode create flow

@mjac0bs mjac0bs added Approved Multiple approvals and ready to merge! and removed Ready for Review labels Apr 2, 2024
@jdamore-linode jdamore-linode merged commit fa7d1bb into linode:develop Apr 3, 2024
18 checks passed
bnussman-akamai pushed a commit to bnussman-akamai/manager that referenced this pull request Apr 4, 2024
@jdamore-linode @bnussman
fix: [M3-7953] - Reset SSH key form on cancel and close (linode#10344)
0f7024f 
* Reset SSH key form on cancel and close

* Added changeset: Reset SSH key form state on cancel
This was referenced Apr 11, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hana-akamai hana-akamai hana-akamai approved these changes

@bnussman-akamai bnussman-akamai bnussman-akamai approved these changes

@mjac0bs mjac0bs mjac0bs approved these changes

Assignees

@jdamore-linode jdamore-linode

Labels
Approved Multiple approvals and ready to merge!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jdamore-linode @mjac0bs @bnussman-akamai @hana-akamai