Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upcoming: [M3-7972] - Invalidate PG queries on Linode create/delete #10366

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

abailly-akamai
Copy link
Contributor

@abailly-akamai abailly-akamai commented Apr 10, 2024

Description 📝

Now that the POST & DELETE linode/instances Alpha endpoint have been updated to work with placement groups, we need to invalidate the related PG if:

  • on POST (create linode) we assign a placement group
  • on DELETE (delete linode) we delete a linode assigned to a placement group

Changes 🔄

  • Invalidate PG queries on Linode create & delete mutations

Preview 📷

Create Linode (and assign to PG) Delete Linode (and unassign from PG)
Screen.Recording.2024-04-10.at.16.28.54.mov
Screen.Recording.2024-04-10.at.16.33.11.mov

How to test 🧪

Prerequisites

  • Using alpha environment and having the "Placement Group" feature flag enabled, either:
    • use your account (need the placement-group customer tag
    • use the pg-user-1 (see creds in 1Password vault)
  • Have at least one Placement Group created

Verification steps

  • See the video above:
    • Create a linode and assign to a PG: confirm UI updates accordingly in the placement group section
    • Delete a linode that has a linode assigned: confirm UI updates accordingly in the placement group section

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@abailly-akamai abailly-akamai self-assigned this Apr 10, 2024
@abailly-akamai abailly-akamai marked this pull request as ready for review April 10, 2024 20:41
@abailly-akamai abailly-akamai requested a review from a team as a code owner April 10, 2024 20:41
@abailly-akamai abailly-akamai requested review from mjac0bs and hana-akamai and removed request for a team April 10, 2024 20:41
Copy link

Coverage Report:
Base Coverage: 81.78%
Current Coverage: 81.78%

@carrillo-erik
Copy link
Contributor

I was able to verify that create and delete/unassign operations worked as expected by the changes. The linode count updated in the UI accordingly and did not observe any regressions.

@hana-akamai hana-akamai added Placement Groups Approved Multiple approvals and ready to merge! labels Apr 11, 2024
Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed:
✅ UI updates accordingly in the placement group section when a linode is created and assigned a PG (either via create flow or the PG details page). Query is invalidated in RQ dev tools.
✅ UI updates accordingly in the placement group section when a linode is deleted and was assigned a PG.

Noticed:

  • Whenever I assign more than one linode to a PG, I receive the non-compliant warning. I'm assuming that's expected? I'm unfamiliar with the details of non-compliant/compliant PGs.
Screen.Recording.2024-04-11.at.8.29.11.AM.mov

@abailly-akamai abailly-akamai merged commit 3dbd2ae into linode:develop Apr 11, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Placement Groups
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants