Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: TopMenu related console errors #10398

Merged

Conversation

bnussman-akamai
Copy link
Member

Description 📝

Preview 📷

Before After
Screenshot 2024-04-23 at 10 54 24 AM Screenshot 2024-04-23 at 10 54 16 AM

How to test 🧪

  • Check out this PR
  • Verify you don't see any console errors related to the Top Menu
  • Verify the top menu buttons for Help and Community...
    • Have working tooltips 💡
    • Have aria-labels 📖
    • Look good and consistent 🎨

As an Author I have considered 🤔

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@bnussman-akamai bnussman-akamai self-assigned this Apr 23, 2024
@bnussman-akamai bnussman-akamai requested a review from a team as a code owner April 23, 2024 14:57
@bnussman-akamai bnussman-akamai requested review from jdamore-linode and hana-akamai and removed request for a team April 23, 2024 14:57
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only changes here are

  • adding React.forwardRef
  • Passing the ref to a/RouterLink

@@ -10,7 +10,7 @@ export const Help = () => {
return (
<TopMenuTooltip title="Help & Support">
<IconButton
aria-label="Help & Support"
accessibleAriaLabel="Help & Support"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes Link happy and sets the aria-label properly

Copy link
Contributor

@jdamore-linode jdamore-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for catching and fixing these! It's so easy for console messages to go unnoticed.

Confirmed on a dev and prod build that the console errors are gone and that the top menu seems to be behaving well! Thanks again!

Copy link

Coverage Report:
Base Coverage: 81.86%
Current Coverage: 81.86%

Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! thanks for fixing

  • Behavior works as expected on browsers tested (Chrome + FF) ✅
  • Semantic HTML + accessibility ✅

@bnussman-akamai bnussman-akamai merged commit d097eb9 into linode:develop Apr 23, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants