Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upcoming: [M3-8012] - Fix PG event text formatting #10420

Merged
merged 8 commits into from
May 2, 2024
Merged

upcoming: [M3-8012] - Fix PG event text formatting #10420

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
39eb6de
upcoming: [M3-8012] - Fix PG event text formatting
carrillo-erik Apr 30, 2024
a78b731
Add changesets
carrillo-erik Apr 30, 2024
520689a
Add placement group compliance events actions
carrillo-erik May 1, 2024
0b59b88
Fix punctuation and add entity labels to toast notifications
carrillo-erik May 1, 2024
8f4667d
Update packages/api-v4/.changeset/pr-10420-upcoming-features-17144841…
carrillo-erik May 1, 2024
477d8f2
Update packages/manager/.changeset/pr-10420-upcoming-features-1714484…
carrillo-erik May 1, 2024
eecd209
Add logic to toast notification in case linode is undefined
carrillo-erik May 2, 2024
c4c5b2d
Merge branch 'upcoming/M3-8012' of https://github.com/carrillo-erik/m…
carrillo-erik May 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/api-v4/.changeset/pr-10420-upcoming-features-1714484172551.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@linode/api-v4": Upcoming Features
---

Updated Placement Group event types ([#10420](https://github.com/linode/manager/pull/10420))
carrillo-erik marked this conversation as resolved.
Show resolved Hide resolved
8 changes: 4 additions & 4 deletions packages/api-v4/src/account/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,11 +359,11 @@ export type EventAction =
| 'nodebalancer_update'
| 'password_reset'
| 'placement_group_assign'
| 'placement_group_created'
| 'placement_group_create'
| 'placement_group_assigned'
| 'placement_group_unassigned'
| 'placement_group_updated'
| 'placement_group_deleted'
| 'placement_group_unassign'
| 'placement_group_update'
| 'placement_group_delete'
| 'profile_update'
| 'stackscript_create'
| 'stackscript_delete'
Expand Down
5 changes: 5 additions & 0 deletions packages/manager/.changeset/pr-10420-upcoming-features-1714484130384.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@linode/manager": Upcoming Features
---

Fixed Placement Group action event formatting ([#10420](https://github.com/linode/manager/pull/10420))
carrillo-erik marked this conversation as resolved.
Show resolved Hide resolved
8 changes: 4 additions & 4 deletions packages/manager/src/features/Events/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,11 +81,11 @@ export const EVENT_ACTIONS: Event['action'][] = [
'nodebalancer_update',
'password_reset',
'placement_group_assign',
'placement_group_created',
'placement_group_create',
'placement_group_assigned',
'placement_group_unassigned',
'placement_group_updated',
'placement_group_deleted',
'placement_group_unassign',
'placement_group_update',
'placement_group_delete',
'profile_update',
'stackscript_create',
'stackscript_delete',
Expand Down
8 changes: 4 additions & 4 deletions packages/manager/src/features/Events/eventMessageGenerator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -717,18 +717,18 @@ export const eventMessageCreators: { [index: string]: CreatorsForStatus } = {
notification: (e) =>
carrillo-erik marked this conversation as resolved.
Show resolved Hide resolved
`Linode ${e.secondary_entity?.label} has been assigned to Placement Group ${e.entity?.label}.`,
},
placement_group_created: {
placement_group_create: {
notification: (e) =>
`Placement Group ${e.entity?.label} has been successfully created.`,
},
placement_group_deleted: {
placement_group_delete: {
notification: (e) => `Placement Group ${e.entity?.label} has been deleted.`,
},
placement_group_unassigned: {
placement_group_unassign: {
notification: (e) =>
`Linode ${e.secondary_entity?.label} has been unassigned from Placement Group ${e.entity?.label}.`,
},
placement_group_updated: {
placement_group_update: {
notification: (e) => `Placement Group ${e.entity?.label} has been updated.`,
},
profile_update: {
Expand Down
4 changes: 2 additions & 2 deletions packages/manager/src/mocks/serverHandlers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1609,14 +1609,14 @@ export const handlers = [
status: 'notification',
});
const placementGroupCreateEvent = eventFactory.buildList(1, {
action: 'placement_group_created',
action: 'placement_group_create',
entity: { id: 999, label: 'PG-1', type: 'placement_group' },
message: 'Placement Group successfully created.',
percent_complete: 100,
status: 'notification',
});
const placementGroupAssignedEvent = eventFactory.buildList(1, {
action: 'placement_group_assigned',
action: 'placement_group_assign',
entity: { id: 990, label: 'PG-2', type: 'placement_group' },
message: 'Placement Group successfully assigned.',
percent_complete: 100,
Expand Down
Loading