-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: [M3-6903] - Replace Select with Autocomplete in: volumes #10437
Conversation
Coverage Report: ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Confirmed that Volume create/attach/detach flows are working as expected, and messed around with the autocomplete for a while and didn't see anything out of the ordinary. Thanks @cpathipa!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that we use an Autocomplete
, we don't need to keep the options
in the shape of { label: string, value: number }
. Can we update remove configList
and pass configs
directly to the Autocomplete
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm also observing this. Also, the spacing with the error appears off, there seems to be some extra padding on the left side. |
Thank you for the feedback, I will look into that.. |
@dwiley-akamai @hana-linode This issue was fixed in the commit b8dbb10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue I noted previously has been fixed ✅
Another issue I noticed (that also happens in prod) is when you try to detach a volume from the Linode Storage tab, the table data doesn't get updated accordingly without a refresh.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seeing all regressions fixed! Thanks @cpathipa!
Description 📝
This PR eliminates redundant logic and reuses ConfigSelect in AttachVolumeDrawer.
Replaced
Select
with Autocomplete inConfigSelect
component.Reused
ConfigSelect
instead of Select inAttachVolumeDrawer
component.Target release date 🗓️
6/10
How to test 🧪
Verification steps
(How to verify changes)
As an Author I have considered 🤔
Check all that apply