Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upcoming: [M3-8077] - Add Distribution Icon to Image Select v2 #10440

Conversation

bnussman-akamai
Copy link
Member

Description πŸ“

  • Adds the distribution icon to the new ImageSelect on the new Linode Create flow πŸ–ΌοΈ
  • Add unit test to ensure Icon renders

Preview πŸ“·

Before After
Screenshot 2024-05-06 at 1 45 22β€―PM Screenshot 2024-05-06 at 1 45 06β€―PM

How to test πŸ§ͺ

Prerequisites

  • Turn on the Linode Create v2 flag using local dev tool

Verification steps

  • Verify you see the distro icon of the selected distribution πŸ‘€
  • Compare styles to production make make sure they look very similar

As an Author I have considered πŸ€”

  • πŸ‘€ Doing a self review
  • ❔ Our contribution guidelines
  • 🀏 Splitting feature into small PRs
  • βž• Adding a changeset
  • πŸ§ͺ Providing/Improving test coverage
  • πŸ” Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • πŸ‘£ Providing comprehensive reproduction steps
  • πŸ“‘ Providing or updating our documentation
  • πŸ•› Scheduling a pair reviewing session
  • πŸ“± Providing mobile support
  • β™Ώ Providing accessibility support

@bnussman-akamai bnussman-akamai self-assigned this May 6, 2024
@bnussman-akamai bnussman-akamai requested a review from a team as a code owner May 6, 2024 17:59
@bnussman-akamai bnussman-akamai requested review from dwiley-akamai and hkhalil-akamai and removed request for a team May 6, 2024 17:59
Copy link

github-actions bot commented May 6, 2024

Coverage Report: βœ…
Base Coverage: 82.01%
Current Coverage: 82.02%

Copy link
Contributor

@hkhalil-akamai hkhalil-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nitpicky, but I noticed the icon appears very slightly off-center, shifted up a few pixels in V2 vs prod. Would be nice to see if we could get it vertically centered.

Prod This PR
Screenshot 2024-05-06 at 3 44 18β€―PM Screenshot 2024-05-06 at 3 44 47β€―PM

Copy link
Contributor

@dwiley-akamai dwiley-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Distribution icon present βœ…

I'm also observing that the positioning is slightly (but noticeably) off

@mjac0bs mjac0bs added the Approved Multiple approvals and ready to merge! label May 8, 2024
@bnussman-akamai
Copy link
Member Author

bnussman-akamai commented May 8, 2024

Working on this! Seems that Safari handles it a bit different than Chrome πŸ˜΅β€πŸ’« @hkhalil-akamai

@bnussman-akamai bnussman-akamai merged commit a368661 into linode:develop May 8, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Linode Create Refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants