Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [M3-8067] - Remove duplicate speedtest helper text in Create Cluster form #10490

Merged

Conversation

mjac0bs
Copy link
Contributor

@mjac0bs mjac0bs commented May 20, 2024

Description 📝

We ended up with two speedtext helper texts displaying on the LKE Create Cluster form. I'm not entirely sure why this happened, but I think it was a combination of deciding where to place the helper text in this form once the pricing link was added and changes to RegionSelect and/or Autocomplete that made the helper text show up where it should be, when it wasn't originally due to some bug.

Changes 🔄

  • Removed one of the helper texts.

Target release date 🗓️

05/28

Preview 📷

Before After
Screenshot 2024-05-20 at 10 55 29 AM Screenshot 2024-05-20 at 10 55 15 AM Screenshot 2024-05-20 at 10 54 40 AM Screenshot 2024-05-20 at 10 54 54 AM

How to test 🧪

Reproduction steps

(How to reproduce the issue, if applicable)

Verification steps

(How to verify changes)

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@mjac0bs mjac0bs self-assigned this May 20, 2024
@mjac0bs mjac0bs requested a review from a team as a code owner May 20, 2024 17:52
@mjac0bs mjac0bs requested review from dwiley-akamai and hana-akamai and removed request for a team May 20, 2024 17:52
Copy link

github-actions bot commented May 20, 2024

Coverage Report:
Base Coverage: 81.52%
Current Coverage: 81.52%

Copy link
Contributor

@hana-akamai hana-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed removal of duplicate speedtest helper text 🧹 . My theory is that it was overlooked as part of resolving a merge conflict 🤔

@hana-akamai hana-akamai added the Add'tl Approval Needed Waiting on another approval! label May 20, 2024
Copy link
Contributor

@dwiley-akamai dwiley-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one instance of the speedtest helper text appears now ✅

@mjac0bs mjac0bs added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! Ready for Review labels May 20, 2024
@mjac0bs mjac0bs merged commit 770fbcf into linode:develop May 20, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants