Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: [M3-8130] - Query Key Factory for Databases #10503

Conversation

bnussman-akamai
Copy link
Member

@bnussman-akamai bnussman-akamai commented May 22, 2024

Description 📝

Updates React Query layer of Databases to adapt our latest patterns

Changes 🔄

  • Updates Database queries to use a query key factory 🏭
  • Updates Database queries and mutations to use the "single object notation" (see here) in efforts to make updating from v4 to v5 easier 📦
  • Updates some Database responses and types to match what the API actually returns 💡

Preview 📷

Note

No UI changes

How to test 🧪

  • Checkout this PR locally and/or test with the internal preview link 🔗
  • Test Database functionality in general 👀
    • Verify general cache updates happen as expected. For example, renaming a database should propagate to all screens
  • Verify all Database automated testing passes ✅

As an Author I have considered 🤔

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@bnussman-akamai bnussman-akamai added React Query Relating to the transition to use React Query DBaaS Relates to Database as a Service labels May 22, 2024
@bnussman-akamai bnussman-akamai self-assigned this May 22, 2024
@bnussman-akamai bnussman-akamai marked this pull request as ready for review May 22, 2024 00:54
@bnussman-akamai bnussman-akamai requested a review from a team as a code owner May 22, 2024 00:54
@bnussman-akamai bnussman-akamai requested review from hana-akamai and jaalah-akamai and removed request for a team May 22, 2024 00:54
Copy link

github-actions bot commented May 22, 2024

Coverage Report:
Base Coverage: 81.63%
Current Coverage: 81.64%

Copy link
Contributor

@jaalah-akamai jaalah-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job with this 🚀
Screenshot 2024-05-29 at 10 35 49 PM

@jaalah-akamai jaalah-akamai added the Add'tl Approval Needed Waiting on another approval! label May 30, 2024
@hana-akamai hana-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels May 30, 2024
@bnussman-akamai bnussman-akamai merged commit 7a5f3b7 into linode:develop May 30, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! DBaaS Relates to Database as a Service React Query Relating to the transition to use React Query
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants