Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Linode Create v2 - UDFs #10507

Merged
merged 3 commits into from
May 23, 2024
Merged

fix: Linode Create v2 - UDFs #10507

merged 3 commits into from
May 23, 2024

Conversation

bnussman-akamai
Copy link
Member

Description 📝

Fixes bugs and console errors with Linode Create v2 User Defined Fields 🐛

Preview 📷

Before After
Screen.Recording.2024-05-22.at.3.34.13.PM.mov
Screen.Recording.2024-05-22.at.3.31.10.PM.mov

How to test 🧪

Prerequisites

  • Enable the Linode Create v2 flag

Verification steps

  • Test UFDs for various StackScripts or marketplace apps
    • To test a multi-select you can use the lillq / Apache, MySQL, Ruby Setup on the community tab

As an Author I have considered 🤔

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@bnussman-akamai bnussman-akamai added the Bug Fixes for regressions or bugs label May 22, 2024
@bnussman-akamai bnussman-akamai self-assigned this May 22, 2024
@bnussman-akamai bnussman-akamai marked this pull request as ready for review May 22, 2024 20:04
@bnussman-akamai bnussman-akamai requested a review from a team as a code owner May 22, 2024 20:04
@bnussman-akamai bnussman-akamai requested review from hana-akamai and AzureLatte and removed request for a team May 22, 2024 20:04
hana-akamai
hana-akamai approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@hana-akamai hana-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get rid of the Select an Option placeholder text when there are option(s) selected?

image

@hana-akamai hana-akamai added the Add'tl Approval Needed Waiting on another approval! label May 23, 2024
AzureLatte
AzureLatte approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@AzureLatte AzureLatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@bnussman-akamai bnussman-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels May 23, 2024
@github-actions GitHub Actions
Copy link

Coverage Report: ✅
Base Coverage: 81.64%
Current Coverage: 81.64%

@bnussman-akamai bnussman-akamai merged commit d5e7bd9 into linode:develop May 23, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AzureLatte AzureLatte AzureLatte approved these changes

@hana-akamai hana-akamai hana-akamai approved these changes

Assignees

@bnussman-akamai bnussman-akamai

Labels
Approved Multiple approvals and ready to merge! Bug Fixes for regressions or bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bnussman-akamai @hana-akamai @AzureLatte @bnussman