feat: [M3-8099] - Improve Linode Clone Power Off based on initial data #10508

mjac0bs · 2024-05-22T20:58:54Z

Description 📝

We'd like to increase the percentage of users powering down their linodes before cloning to reduce the chance of data corruption. We'd also like to capture more analytics data to find out how many users are clicking the new "Power Off" button.

Changes 🔄

For both the v1 and v2 Clone flows:
- Switched the order of the bullet points so that "To help avoid data corruption during the cloning process, we recommend powering off your Compute Instance prior to cloning." comes first in the list.
- Bolded the text "avoid data corruption".
- Added an analytics event firing on click of the Power Off button.
- Users can see their linode's status and power it off in tablet and mobile view in the Linode Clone flow.
- Added unit test coverage for SelectLinodeCard changes

Target release date 🗓️

6/10

Preview 📷

Before	After


N/A

How to test 🧪

Prerequisites

(How to setup test environment)

Have at least two linodes on your account - one powered on and one powered off.
Have analytics logging enabled in the browser console.

Reproduction steps

(How to reproduce the issue, if applicable)

Go to https://cloud.linode.com/linodes/create?type=Clone%20Linode.
Change the screen to mobile view.
Observe there is no way to power off a selected, running linode when viewing selection cards.
Change the screen back to desktop view and select your powered on linode.
Click the Power Off button and observe in the browser console that there is no analytics event fired when the button is clicked.
Observe the notice copy has two bullets and may be easy to skim/ignore information about possible corruption.

Verification steps

(How to verify changes)

With this PR checked out, go to http://localhost:3000/linodes/create?type=Clone%20Linode.
Change the screen to mobile view.
Confirm that each linode's status is now displaying on the cards.
Select a powered on linode. Confirm that the selected card shows a Power Off button, and that clicking it powers off the linode and fires an analytics event.
Change the screen back to desktop view and select your powered on linode.
Click the Power Off button and confirm in the browser console that is also an analytics event fired when the button is clicked in the table view.
Observe the notice copy has switched the order of the bullets and bolded text to encourage users to read it.
Go to http://localhost:3000/linodes/create?type=Backups. (Turn the MSW on if you don't have any backups.) Change the screen to mobile view and confirm that status displays on the cards, but selecting a card of a powered on linode will not display the Power Off button.
Turn on the Linode Create v2 flag in the dev tools and confirm all the above changes are also present for the new version of the create flow.

As an Author I have considered 🤔

Check all that apply

mjac0bs · 2024-05-22T21:00:08Z

...ages/manager/src/features/Linodes/LinodesCreate/SelectLinodePanel/SelectLinodePanel.test.tsx

@@ -197,21 +197,6 @@ describe('SelectLinodePanel (cards, mobile)', () => {
    ).toHaveTextContent(defaultProps.linodes[0].label);
  });

-  it('displays the heading, notices and error', () => {


This was a duplicate test the linter notified me of. See L99-L112.

…n before cloning

abailly-akamai

Nice and clean PR! Checks added underneath. I possibly did not test the right things?

go to http://localhost:3000/linodes/create?type=Clone%20Linode, Change the screen to mobile view. Confirm that each linode's status is now displaying on the cards. ✅
Select a powered on linode. Confirm that the selected card shows a Power Off button, and that clicking it powers off the linode and fires an analytics event. (❌ (maybe intentional?) it does work for both v1 and v2 flows on mobile, but on desktop the event does not fire in v2)
Go to http://localhost:3000/linodes/create?type=Backups. (Turn the MSW on if you don't have any backups.) Change the screen to mobile view and confirm that status displays on the cards, but selecting a card of a powered on linode will not display the Power Off button. ✅
Change the screen back to desktop view and select your powered on linode. Click the Power Off button and confirm in the browser console that is also an analytics event fired when the button is clicked in the table view. ❌ is that for Backups?? I don't see a power button at all in the backups flow)
Observe the notice copy has switched the order of the bullets and bolded text to encourage users to read it.
Turn on the Linode Create v2 flag in the dev tools and confirm all the above changes are also present for the new version of the create flow. ❌ see comment in bullet 2

github-actions · 2024-05-23T15:05:18Z

Coverage Report: ❌
Base Coverage: 81.74%
Current Coverage: 81.73%

mjac0bs · 2024-05-23T15:18:23Z

@abailly-akamai Thanks for the review:

Select a powered on linode. Confirm that the selected card shows a Power Off button, and that clicking it powers off the linode and fires an analytics event. (❌ (maybe intentional?) it does work for both v1 and v2 flows on mobile, but on desktop the event does not fire in v2)

This was a mistake - thank you for catching! The Power Off button has been tagged in v2 flow in a1e0053.

Screen.Recording.2024-05-23.at.8.12.08.AM.mov

Change the screen back to desktop view and select your powered on linode. Click the Power Off button and confirm in the browser console that is also an analytics event fired when the button is clicked in the table view. ❌ is that for Backups?? I don't see a power button at all in the backups flow)

My bad, sorry - my testing instructions were unclear because I went back and added the bullet about Backups after the fact and put it out of order. You were observing the intended behavior - no Power Off option (or analytics) for Backups, yes Power Off option (and analytics) for Clone. This should be the case for v1 and v2 flows. I've corrected the testing instructions.

abailly-akamai

All good after fix and confirming all steps ✅

Nit: the alignment of the status icon/button feels a bit off

mjac0bs · 2024-05-24T14:04:27Z

@abailly-akamai How does this alignment look?

jaalah-akamai

👏

abailly-akamai · 2024-05-24T14:48:01Z

Looks great @mjac0bs thx for the fixes - ship it 🚢

mjac0bs added 5 commits May 22, 2024 10:33

Remove duplicate test

4cdfc3f

Swap notice list order and bold key words

1f4742b

Add analytics event on power off button

8e9ef26

Add status and power off button to linode selection card

cf88d7b

Prevent power off button from displaying on cards outside clone flow

6d2de3d

mjac0bs self-assigned this May 22, 2024

Add test coverage for SelectLinodeCard

22bada9

mjac0bs commented May 22, 2024

View reviewed changes

Added changeset: Improvements to Clone flow to encourage powering dow…

6a24978

…n before cloning

mjac0bs marked this pull request as ready for review May 22, 2024 22:08

mjac0bs requested a review from a team as a code owner May 22, 2024 22:08

mjac0bs requested review from jdamore-linode and abailly-akamai and removed request for a team May 22, 2024 22:08

mjac0bs added the Ready for Review label May 22, 2024

Merge branch 'develop' into M3-8099-improve-linode-clone-power-off

5197953

abailly-akamai reviewed May 23, 2024

View reviewed changes

Address feedback: add missing event in v2 flow

a1e0053

abailly-akamai approved these changes May 23, 2024

View reviewed changes

mjac0bs requested a review from jaalah-akamai May 23, 2024 15:37

Address feedback: improve alignment

8dd052f

mjac0bs added the Add'tl Approval Needed Waiting on another approval! label May 24, 2024

mjac0bs requested a review from hkhalil-akamai May 24, 2024 14:06

jaalah-akamai approved these changes May 24, 2024

View reviewed changes

jaalah-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels May 24, 2024

mjac0bs removed the Ready for Review label May 24, 2024

mjac0bs merged commit 432909f into linode:develop May 24, 2024
18 checks passed

jaalah-akamai mentioned this pull request Jun 6, 2024

Release v1.121.0 - release → staging #10553

Merged

cpathipa mentioned this pull request Jun 10, 2024

Release v1.121.0 - staging → master #10563

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: [M3-8099] - Improve Linode Clone Power Off based on initial data #10508

feat: [M3-8099] - Improve Linode Clone Power Off based on initial data #10508

mjac0bs commented May 22, 2024 •

edited

Loading

mjac0bs May 22, 2024

abailly-akamai left a comment

github-actions bot commented May 23, 2024 •

edited

Loading

mjac0bs commented May 23, 2024

abailly-akamai left a comment

mjac0bs commented May 24, 2024

jaalah-akamai left a comment

abailly-akamai commented May 24, 2024

feat: [M3-8099] - Improve Linode Clone Power Off based on initial data #10508

feat: [M3-8099] - Improve Linode Clone Power Off based on initial data #10508

Conversation

mjac0bs commented May 22, 2024 • edited Loading

Description 📝

Changes 🔄

Target release date 🗓️

Preview 📷

How to test 🧪

Prerequisites

Reproduction steps

Verification steps

As an Author I have considered 🤔

mjac0bs May 22, 2024

Choose a reason for hiding this comment

abailly-akamai left a comment

Choose a reason for hiding this comment

github-actions bot commented May 23, 2024 • edited Loading

mjac0bs commented May 23, 2024

abailly-akamai left a comment

Choose a reason for hiding this comment

mjac0bs commented May 24, 2024

jaalah-akamai left a comment

Choose a reason for hiding this comment

abailly-akamai commented May 24, 2024

mjac0bs commented May 22, 2024 •

edited

Loading

github-actions bot commented May 23, 2024 •

edited

Loading