Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [M3-8042] - Firewall landing device request with -1 ID #10509

Merged

Conversation

hana-akamai
Copy link
Contributor

@hana-akamai hana-akamai commented May 22, 2024

Description 📝

Fix bug where we were trying to fetch devices with an invalid Firewall id

Preview 📷

Before After
image image

How to test 🧪

Reproduction steps

(How to reproduce the issue, if applicable)

  • Go to the Firewalls landing page /firewalls and observe the devices network request. Notice failed device requests with a -1 firewall id

Verification steps

(How to verify changes)

  • Go to the Firewalls landing page /firewalls and observe the devices network request. Notice no more failed device requests

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@hana-akamai hana-akamai added the Bug Fixes for regressions or bugs label May 22, 2024
@hana-akamai hana-akamai self-assigned this May 22, 2024
selectedFirewallId={selectedFirewallId}
selectedFirewallLabel={selectedFirewall?.label ?? ''}
/>
{selectedFirewallId && (
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only render the dialog if we have the Firewall ID so we don't have to pass in -1 to the query

@hana-akamai hana-akamai marked this pull request as ready for review May 22, 2024 22:01
@hana-akamai hana-akamai requested a review from a team as a code owner May 22, 2024 22:01
@hana-akamai hana-akamai requested review from bnussman-akamai and jaalah-akamai and removed request for a team May 22, 2024 22:01
Copy link
Contributor

@jdamore-linode jdamore-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hana-linode! Confirmed that the requests for -1 are gone and that Firewall functionality continues to work as expected

Copy link
Member

@bnussman-akamai bnussman-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed API request issue is fixed ✅
Dialog animation still looks good ✅

@hana-akamai hana-akamai added the Approved Multiple approvals and ready to merge! label May 23, 2024
@hana-akamai hana-akamai merged commit 32f836a into linode:develop May 23, 2024
18 checks passed
@hana-akamai hana-akamai deleted the M3-8042-firewall-device-request branch May 23, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Bug Fixes for regressions or bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants