-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [M3-8042] - Firewall landing device request with -1 ID #10509
fix: [M3-8042] - Firewall landing device request with -1 ID #10509
Conversation
selectedFirewallId={selectedFirewallId} | ||
selectedFirewallLabel={selectedFirewall?.label ?? ''} | ||
/> | ||
{selectedFirewallId && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only render the dialog if we have the Firewall ID so we don't have to pass in -1 to the query
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @hana-linode! Confirmed that the requests for -1 are gone and that Firewall functionality continues to work as expected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed API request issue is fixed ✅
Dialog animation still looks good ✅
Description 📝
Fix bug where we were trying to fetch devices with an invalid Firewall id
Preview 📷
How to test 🧪
Reproduction steps
(How to reproduce the issue, if applicable)
/firewalls
and observe the devices network request. Notice failed device requests with a -1 firewall idVerification steps
(How to verify changes)
/firewalls
and observe the devices network request. Notice no more failed device requestsAs an Author I have considered 🤔
Check all that apply