Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Cypress test creating an Image without a cy-test prefixed label #10510

Conversation

bnussman-akamai
Copy link
Member

Description 📝

  • I made a mistake in feat: [M3-8103] - Refactor Image Create and Add Tags #10471 (specifically here)
  • I removed the randomLabel() from the createImage call because at the time, it didn't occur to me that the image label mattered for the sake of the test. I was correct in that sense, but I failed to remember that cypress only cleans up entities that are prefixed with cy-test 🤦 . Our test accounts are filling up with Images that are not being cleaned up as a result 😣
  • This PR adds back the randomLabel() so the image is created with a label that will be cleaned up

How to test 🧪

  • Verify the image created by create-stackscripts.spec.ts are prefixed with cy-test

As an Author I have considered 🤔

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@bnussman-akamai bnussman-akamai self-assigned this May 22, 2024
@bnussman-akamai bnussman-akamai requested a review from a team as a code owner May 22, 2024 23:30
@bnussman-akamai bnussman-akamai requested review from jdamore-linode and removed request for a team May 22, 2024 23:30
Copy link

Coverage Report:
Base Coverage: 81.64%
Current Coverage: 81.64%

Copy link
Contributor

@jdamore-linode jdamore-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch/fix Banks! I'll take care of keeping the Images cleaned up while this makes its way into peoples branches, etc.

@bnussman-akamai bnussman-akamai added Add'tl Approval Needed Waiting on another approval! e2e Indicates that a PR touches Cypress tests in some way labels May 23, 2024
@jdamore-linode jdamore-linode requested a review from AzureLatte May 28, 2024 14:02
Copy link
Contributor

@AzureLatte AzureLatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@bnussman-akamai bnussman-akamai removed the Add'tl Approval Needed Waiting on another approval! label May 29, 2024
@bnussman-akamai bnussman-akamai merged commit 5a82040 into linode:develop May 29, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Indicates that a PR touches Cypress tests in some way
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants