Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [M3-8164] - regions length check #10519

Merged
merged 3 commits into from
May 29, 2024
Merged

fix: [M3-8164] - regions length check #10519

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ceced84
fix: [M3-8164] - regions length check
cpathipa May 28, 2024
5ea6781
Added changeset: fix regions length check in HostNameTableCell
cpathipa May 28, 2024
c60eb2d
PR feedback: @bnussman and @DevDW
cpathipa May 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/manager/.changeset/pr-10519-upcoming-features-1716918242639.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@linode/manager": Upcoming Features
---

fix regions length check in HostNameTableCell ([#10519](https://github.com/linode/manager/pull/10519))
2 changes: 1 addition & 1 deletion .../manager/src/features/ObjectStorage/AccessKeyLanding/AccessKeyTable/HostNameTableCell.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export const HostNameTableCell = ({

const { regions } = storageKeyData;

if (!regionsLookup || !regionsData || !regions) {
if (!regionsLookup || !regionsData || !regions.length) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our length checks are normally more explicit, i.e., regions.length === 0.

Did UX share any ideas other than an empty cell for these cases? Maybe "None" or "N/A"?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ for the explicit length check (regions.length === 0)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call @dwiley-akamai None makes sense to me. Looks like we are using it in VPC as well. However, I will confirm with UX and get back on this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UX is confirmed on showing 'None'.

return <TableCell />;
}

Expand Down
Loading