upcoming: [M3-8014] - Update APIv4 and Validation packages based on Image Service spec #10541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkhalil-akamai
added
@linode/api-v4
hkhalil-akamai
requested review from
jdamore-linode and
abailly-akamai
and removed request for
a team
|
Coverage Report: ✅ |
| @@ -12,7 +12,7 @@ export const baseImageSchema = object({ | |||
| label: labelSchema.notRequired(), | |||
| description: string().notRequired().min(1).max(65000), | |||
| cloud_init: boolean().notRequired(), | |||
| tags: array(string()).notRequired(), | |||
| tags: array(string().min(3).max(50)).max(500).notRequired(), | |||
There was a problem hiding this comment.
I wonder if we have a validation schema we can share across linodes, volumes, etc for tags
There was a problem hiding this comment.
Are the requirements for tags always the same across the API?
There was a problem hiding this comment.
I'm not 100% sure, but I would assume they are. Might require some investigation
Comment on lines
+13
to
+14
| | 'pending deletion' | ||
| | 'pending replication' |
There was a problem hiding this comment.
Maybe we should ask for verification on this... It would be very unusual to have a status with spaces instead of underscores so I'm surprised this is what was reflected in the spec
There was a problem hiding this comment.
Confirmed by Priyank Patel on API team
bnussman-akamai
approved these changes
Jun 3, 2024
abailly-akamai
approved these changes
Jun 4, 2024
Comment on lines
+13
to
+14
| | 'pending deletion' | ||
| | 'pending replication' |
hkhalil-akamai
force-pushed
the
M3-8014-image-service-api-changes
branch
from
2514286 to
ee9d693
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Updates the
api-v4andvalidationpackages to reflect the API spec.Changes 🔄
total_sizeandregionsfield toImagetypeImageRegion'distributed-images'updateImageRegionsSDK methodupdateImageRegionsSchemaTarget release date 🗓️
6/10
How to test 🧪
Prerequisites
Note
These changes are only available in alpha. Additionally, this functionality is not working currently as image service development is in progress.
total_sizeandregionsfields matches what is returned by the APIupdateImageRegionsAPI method results in a 200 response code