Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: [M3-8329] - Clean up Gravatar analytics events #10661

Merged

Conversation

mjac0bs
Copy link
Contributor

@mjac0bs mjac0bs commented Jul 9, 2024

Description 📝

In #10389, we tagged Gravatar components to determine whether we can justify sunsetting support for it. Now that we have collected data for a period of time and this Product decision has been made, we can save analytics calls and costs by untagging Gravatar-related analytics.

Changes 🔄

  • Removes analytics events sendHasGravatarEvent and sendManageGravatarEvent

Target release date 🗓️

7/22

How to test 🧪

Prerequisites

(How to setup test environment)

  • Ensure your REACT_APP_ADOBE_ANALYTICS_URL environment variable is set in .env
  • Run window._satellite.setDebug(true) in your browser console
  • Refresh your page

Verification steps

(How to verify changes)

Before After
When the page loads, verify you do not see an analytics event like this if you have a Gravatar Screenshot 2024-04-18 at 3 57 07 PM
When the page loads, verify you do not see an event like this if you don't have a Gravatar Screenshot 2024-04-18 at 4 01 36 PM
Verify you do not see this event when you click Manage Photo on the http://localhost:3000/profile/display page Screenshot 2024-04-18 at 4 04 14 PM

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@mjac0bs mjac0bs added the Analytics Relating to Analytics migration project or Adobe Analytics label Jul 9, 2024
@mjac0bs mjac0bs self-assigned this Jul 9, 2024
@mjac0bs mjac0bs requested a review from a team as a code owner July 9, 2024 17:57
@mjac0bs mjac0bs requested review from jdamore-linode and dwiley-akamai and removed request for a team July 9, 2024 17:57
Copy link
Member

@bnussman-akamai bnussman-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🙏

Copy link

github-actions bot commented Jul 9, 2024

Coverage Report:
Base Coverage: 82.26%
Current Coverage: 82.31%

Copy link
Contributor

@dwiley-akamai dwiley-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed sendHasGravatarEvent and sendManageGravatarEvent have been removed ✅

@mjac0bs mjac0bs merged commit c632152 into linode:develop Jul 9, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Analytics Relating to Analytics migration project or Adobe Analytics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants