refactor: [M3-8143] - Improve PowerActionsDialog #10667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carrillo-erik
requested review from
bnussman-akamai and
AzureLatte
and removed request for
a team
|
Coverage Report: ✅ |
bnussman-akamai
approved these changes
Jul 15, 2024
| @@ -96,7 +97,7 @@ export const LinodeRebuildDialog = (props: Props) => { | |||
| maxWidth="md" | |||
| onClose={onClose} | |||
| open={open} | |||
| title={`Rebuild Linode ${linode?.label ?? ''}`} | |||
| title={`Rebuild Linode ${linodeLabel ?? ''}`} | |||
| > | |||
| <StyledDiv> | |||
| {unauthorized && <LinodePermissionsError />} | |||
There was a problem hiding this comment.
This components needs its form state reset on either close or open - especially since the Config Select clearable prop does not seem to any effect. Ex: select a config and close the modal, open it back up and the previously selected config will be selected and unclearable.
There was a problem hiding this comment.
@abailly-akamai This issue was also occurring with onSubmit(), both cases for the state reset have been addressed. Also, the isClearable prop now works as expected.
carrillo-erik
requested review from
jdamore-linode
and removed request for
a team
AzureLatte
approved these changes
Jul 16, 2024
abailly-akamai
approved these changes
Jul 16, 2024
This was referenced Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
This PR helps improve the janky loading state of the
PowerActionsDialogby removing the flash of content when a dialog or drawer is rendered. The user is now shown helper text in the Reboot Linode dialog above the config select component.Changes 🔄
List any change relevant to the reviewer.
useLinodeQuery.linodeLabelprop to child component to eliminate the flash of content.default exportswithnamed exports.Target release date 🗓️
07/22/2024
Preview 📷
PowerActionsDialog-before.mov
PowerActionsDialog-after.mov
How to test 🧪
Prerequisites
(How to setup test environment)
Verification steps
(How to verify changes)
LinodeActionMenuand select any of the options.As an Author I have considered 🤔
Check all that apply