Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: [M3-6901, M3-6914] - Replace Select with Autocomplete in: kubernetes #10673

Conversation

pmakode-akamai
Copy link
Contributor

@pmakode-akamai pmakode-akamai commented Jul 11, 2024

Description 📝

We want to get rid of our dependency on react-select for accessibility reasons and to consolidate our usage of third-party libraries.

Changes 🔄

  • Replaced Select with Autocomplete in CreateCluster component.
  • Added disableClearable prop condition to Autocomplete to prevent uncontrolled behavior with an initial empty value.

Target release date 🗓️

22nd July, 2024

How to test 🧪

Verification steps

(How to verify changes)

  • Navigate to http://localhost:3000/kubernetes/create
  • Verify 'Kubernetes Version' dropdown functionality remains unchanged when using Autocomplete.
  • Verify that the disableClearable prop condition is correctly applied to Autocomplete to prevent uncontrolled behavior when the initial value is empty.

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@pmakode-akamai pmakode-akamai requested a review from a team as a code owner July 11, 2024 15:09
@pmakode-akamai pmakode-akamai requested review from jdamore-linode and dwiley-akamai and removed request for a team July 11, 2024 15:09
@pmakode-akamai pmakode-akamai self-assigned this Jul 11, 2024
@pmakode-akamai pmakode-akamai added LKE Related to Linode Kubernetes Engine offerings Missing Changeset Ready for Review and removed Missing Changeset labels Jul 11, 2024
Copy link

github-actions bot commented Jul 11, 2024

Coverage Report:
Base Coverage: 82.48%
Current Coverage: 82.48%

Copy link
Contributor

@dwiley-akamai dwiley-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kubernetes Version dropdown functioning as expected ✅
Cannot clear Kubernetes Version dropdown ✅

I observed this console warning:

Screenshot 2024-07-11 at 4 50 08 PM

To get rid of that, you should be able to add something like

isOptionEqualToValue={(option, value) => option.value === value.value}

as a prop when Autocomplete is used in CreateCluster.tsx. See this comment for more context, and you can search the codebase for other instances of isOptionEqualToValue for examples

@pmakode-akamai pmakode-akamai force-pushed the M3-6914-replace-select-with-autocomplete-in-k8s branch from d8a01c2 to be13c7c Compare July 15, 2024 04:33
@pmakode-akamai pmakode-akamai added Add'tl Approval Needed Waiting on another approval! and removed Ready for Review labels Jul 15, 2024
@pmakode-akamai pmakode-akamai force-pushed the M3-6914-replace-select-with-autocomplete-in-k8s branch from aeb325b to 6149806 Compare July 15, 2024 13:29
@pmakode-akamai pmakode-akamai force-pushed the M3-6914-replace-select-with-autocomplete-in-k8s branch from 47bc5a1 to 0f4848f Compare July 16, 2024 05:12
@pmakode-akamai pmakode-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Jul 16, 2024
@pmakode-akamai pmakode-akamai merged commit 6c6d94e into linode:develop Jul 16, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! LKE Related to Linode Kubernetes Engine offerings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants