-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: [M3-6901, M3-6914] - Replace Select with Autocomplete in: kubernetes #10673
refactor: [M3-6901, M3-6914] - Replace Select with Autocomplete in: kubernetes #10673
Conversation
Coverage Report: ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kubernetes Version
dropdown functioning as expected ✅
Cannot clear Kubernetes Version
dropdown ✅
I observed this console warning:
To get rid of that, you should be able to add something like
isOptionEqualToValue={(option, value) => option.value === value.value}
as a prop when Autocomplete
is used in CreateCluster.tsx
. See this comment for more context, and you can search the codebase for other instances of isOptionEqualToValue
for examples
packages/manager/.changeset/pr-10673-tech-stories-1720710990405.md
Outdated
Show resolved
Hide resolved
d8a01c2
to
be13c7c
Compare
packages/manager/src/features/Kubernetes/CreateCluster/CreateCluster.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/Kubernetes/CreateCluster/CreateCluster.tsx
Outdated
Show resolved
Hide resolved
aeb325b
to
6149806
Compare
packages/manager/src/features/Kubernetes/CreateCluster/CreateCluster.tsx
Outdated
Show resolved
Hide resolved
47bc5a1
to
0f4848f
Compare
Description 📝
We want to get rid of our dependency on react-select for accessibility reasons and to consolidate our usage of third-party libraries.
Changes 🔄
Select
with Autocomplete inCreateCluster
component.disableClearable
prop condition toAutocomplete
to prevent uncontrolled behavior with an initial empty value.Target release date 🗓️
22nd July, 2024
How to test 🧪
Verification steps
(How to verify changes)
Autocomplete
.disableClearable
prop condition is correctly applied toAutocomplete
to prevent uncontrolled behavior when the initial value is empty.As an Author I have considered 🤔
Check all that apply