Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: [M3-7432] - Update Managed Queries to use Query Key Factory #10679

Conversation

bnussman-akamai
Copy link
Member

@bnussman-akamai bnussman-akamai commented Jul 15, 2024

Description 📝

  • Updates Managed Queries to use a query key factory 🏭
  • Fixes breaking changes in preparation for v5 (see here) 🔨
  • Doesn't change any application logic, just switches over to the factory

How to test 🧪

Prerequisites

  • Use the MSW, use an account with managed enabled, or enable managed on your account

Verification steps

  • Verify managed create, update, and delete actions work as expected 👀
  • Verify all automated testing for managed passes ✅

As an Author I have considered 🤔

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@bnussman-akamai bnussman-akamai self-assigned this Jul 15, 2024
@bnussman-akamai bnussman-akamai requested a review from a team as a code owner July 15, 2024 19:33
@bnussman-akamai bnussman-akamai requested review from hkhalil-akamai and abailly-akamai and removed request for a team July 15, 2024 19:33
@bnussman-akamai bnussman-akamai added React Query Relating to the transition to use React Query Ready for Review labels Jul 15, 2024
Copy link

github-actions bot commented Jul 15, 2024

Coverage Report:
Base Coverage: 82.48%
Current Coverage: 82.48%

Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling those.

Tested all managed flows and did not encounter any regression ✅

Copy link
Contributor

@hkhalil-akamai hkhalil-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes and manual testing looks good -- Nice work!

@bnussman-akamai bnussman-akamai merged commit 284b358 into linode:develop Jul 16, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
React Query Relating to the transition to use React Query Ready for Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants