Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Image Upload Toast Support Link #10680

Merged

Conversation

bnussman-akamai
Copy link
Member

@bnussman-akamai bnussman-akamai commented Jul 15, 2024

Description 📝

  • Fixes a bug in useToastNotifications.tsx that caused a support ticket link to not show
  • The "fix" is basically just to use toLowerCase to ignore casing. The event from the API said contact support, but Cloud Manager was checking for contact Support

Target release date 🗓️

  • July 22, 2024

Preview 📷

Before After
Screenshot 2024-07-15 at 4 52 13 PM Screenshot 2024-07-15 at 4 52 21 PM

How to test 🧪

  • gzip something that is not an Image
  • Try uploading it in dev
  • Verify the toast you see has a support link and does not appear broken

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@bnussman-akamai bnussman-akamai added the Bug Fixes for regressions or bugs label Jul 15, 2024
@bnussman-akamai bnussman-akamai self-assigned this Jul 15, 2024
@bnussman-akamai bnussman-akamai requested a review from a team as a code owner July 15, 2024 21:02
@bnussman-akamai bnussman-akamai requested review from mjac0bs and jaalah-akamai and removed request for a team July 15, 2024 21:02
Copy link

github-actions bot commented Jul 15, 2024

Coverage Report:
Base Coverage: 82.34%
Current Coverage: 82.34%

Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching and fixing.

@mjac0bs mjac0bs added the Add'tl Approval Needed Waiting on another approval! label Jul 15, 2024
Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! prob want a changeset here

@mjac0bs mjac0bs added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Jul 16, 2024
@bnussman-akamai bnussman-akamai merged commit 0bc019d into linode:develop Jul 16, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Bug Fixes for regressions or bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants