fix: [M3-8361] - Fix column headers for Automatic Images #10696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkhalil-akamai
added
Bug
hkhalil-akamai
requested review from
carrillo-erik and
AzureLatte
and removed request for
a team
@hkhalil-akamai Wondering if we should branch off the release branch and get it in there for Monday? |
|
Fix looks good! Thanks for doing this one 🙏 I do this we should target the release branch like @mjac0bs suggested |
hkhalil-akamai
force-pushed
the
M3-8361-automatic-images-headers
branch
from
a43c00a to
d96cba5
Compare
|
@mjac0bs @bnussman-akamai rebased this PR on to the release branch and updated the changelog |
bnussman-akamai
approved these changes
Jul 19, 2024
|
Coverage Report: ✅ |
mjac0bs
approved these changes
Jul 19, 2024
mjac0bs
added
Approved
|
CI tests are still failing despite multiple retries -- going to go ahead with the merge anyways since none of the tests seem related. Many of these tests have been fixed in develop via #10698. |
|
CC @carrillo-erik merging this directly into staging to include it in Monday's release. |
hkhalil-akamai
merged commit 733950c
into
linode:release-v1.124.0
18 of 19 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Fixes the "Created" and "Size" headers pointing to the wrong columns in the Automatic Images section of
ImagesLanding. This bug was introduced in #10545.Target release date 🗓️
ASAP
Preview 📷
How to test 🧪
Verification steps
Navigate to the images landing and verify that the Automatic Images headers point to the correct columns under all breakpoints (sm, md and lg).