fix: [M3-8466] - Improve validation rules for create bucket schema #10842
Conversation
jaalah-akamai
requested review from
mjac0bs and
hkhalil-akamai
and removed request for
a team
jaalah-akamai
added
Bug
|
Coverage Report: ✅ |
| /^[a-z0-9.-]*$/, | ||
| 'Label must consist only of lowercase letters, numbers, . (period), and - (dash).' |
There was a problem hiding this comment.
Should we also check for the restriction that names cannot have adjacent periods or dashes?
The following regex could work for that: ^(?!.*[.-]{2})[a-z0-9.-]+$
There was a problem hiding this comment.
They also can't start with anything but a letter or a number, though that's more of an edge case like the above.
| /^[a-z0-9.-]*$/, | ||
| 'Label must consist only of lowercase letters, numbers, . (period), and - (dash).' |
There was a problem hiding this comment.
They also can't start with anything but a letter or a number, though that's more of an edge case like the above.
| "@linode/validation": Fixed | ||
| --- | ||
|
|
||
| Error validation for letter casing when creating object storage bucket now correctly appears for labels. ([#10842](https://github.com/linode/manager/pull/10842)) |
There was a problem hiding this comment.
| Error validation for letter casing when creating object storage bucket now correctly appears for labels. ([#10842](https://github.com/linode/manager/pull/10842)) | |
| Lack of `label` error validation for letter casing when creating Object Storage bucket ([#10842](https://github.com/linode/manager/pull/10842)) |
Suggestion is based on our best practices:
For Fixed changesets, describe the bug that needed to be fixed, rather than the fix itself. (e.g. say "Missing button labels in action buttons" rather than "Make label prop required for action buttons").
Begin a changeset with a capital letter, but do not end it with a period; it's not a complete sentence.
Description 📝
The API currently returns an error when creating buckets, incorrectly checking for 'name' instead of 'label'. While a fix for this issue is planned for the future, we can improve our validation in the interim.
Changes 🔄
Target release date 🗓️
N/A
Preview 📷
How to test 🧪
Prerequisites
Reproduction steps
Verification steps
As an Author I have considered 🤔
Check all that apply