-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change: [M3-8377, M3-8579] - Move Region section above Images in Linode Create and update default OS to Ubuntu 24.04 LTS #10858
change: [M3-8377, M3-8579] - Move Region section above Images in Linode Create and update default OS to Ubuntu 24.04 LTS #10858
Conversation
</Box> | ||
</Paper> | ||
<Stack spacing={3}> | ||
<Region /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that Region
is rendered in these components, it is more susceptible to re-renders if any state in this component changes.
Could we somehow place Region
outside of these subcomponents. I think it would help ensure we keep Linode Create v2 performant. Also, rendering a single instance of Region
at a higher level will keep Linode Create v2 easy to understand from a code perspective.
This might be tricky with how the Tabs work but maybe this is still possible?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bnussman-akamai Hmm what about memoizing the Region
component?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would help, but I still think it would be great if we could keep one instance of <Region />
in the JSX so the JSX conceptually matches up with the UI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bnussman-akamai Pushed the memo change. I tried keeping one instance of Region
/ having it at a higher level but since it's not always in the same place, that makes it difficult. This was the cleanest solution I could come up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohhhh. I didn't realize this only applied to the Image tabs. My fault. I'll think if there are any other options
Coverage Report: ✅ |
Looks like the |
test failures for
might also be related - ran them locally and the above failed
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ty Hana! 🎉
✅ confirmed region moved to top for Linode Create flow
✅ confirmed default is now Ubuntu 24.04
✅ double checked cypress tests, failing test passed locally so doesn't seem related to this pr
am curious about the ongoing thread, if there was another potential solution? 👀
Yeah, not sure if there's another solution that doesn't require a good amount of refactoring 😅 |
Description 📝
No changes have been made in the Backups/Clone tab since they don't have an Images section
Preview 📷
How to test 🧪
Verification steps
(How to verify changes)
As an Author I have considered 🤔
Check all that apply