-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change: increased block storage max volume size to 16TB #10865
Conversation
cc: @dajahi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me - I didn't notice any other places we may need to update this. I tagged others who are working on this feature to double check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would we need a changeset for this @jaalah-akamai?
cc: @abailly-akamai - I updated the release PR and our internal changelog doc |
Coverage Report: ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go. Side note, not sure we need to have three separate const for each package. APIv4 could be the source of truth for this one and we remove the others.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go. Side note, not sure we need to have three separate const for each package. APIv4 could be the source of truth for this one and we remove the others.
I think it would make sense to get rid of the /manager
one and import directly from api-v4
for Cloud's purposes, but validation
should be able to standalone with no api-v4
imports (I did a quick search to see if we do any currently and I didn't find any)
I agree with @abailly-akamai and @dwiley-akamai but rather than using api-v4 as the source of truth, I think validation should be the source of truth because the dependence is like this: validation ➡️ api-v4 ➡️ manager (or just validation ➡️ manager) |
2986d19
into
linode:release-v1.127.0
Description 📝
The API is being updated to increase the max size for block storage volumes to 16TB, these are the changes necessary in the front end
Changes 🔄