-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [M3-8519] - Objects Table Refreshing Logic #10927
Conversation
87d98d6
to
87bb682
Compare
Coverage Report: ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good. Why we need to get the data using getQueryData
rather than just using the data
returned by the hook?
Also, we might be able to update the updateStore
function to use the getObjectBucketObjectsQueryKey
util you created
packages/manager/src/features/ObjectStorage/BucketDetail/BucketDetail.tsx
Outdated
Show resolved
Hide resolved
87bb682
to
f945ef8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice concise fix @dchyrva-akamai 👍
Code looks good and confirmed fix with objects now showing up in the table underneath as they are uploaded. ✅
I also tested Obj feature as a whole (delete operations etc) and did not notice any regression ✅
Hello @bnussman-akamai When several objects are added simultaneously, the component is re-rendered only after all of them have been added. This means that the |
First of all, nice work - this works. I just want to toss out an alternative... I'm interested in what you all think about about reverting back to using the data from the hook (I like the term
|
Hello @bnussman-akamai |
I agree. We should keep updating the store manually.
I'm a bit surprised this is happening, but the fix makes sense! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making that getObjectBucketObjectsQueryKey
helper function!
Description 📝
After uploading several files into the object storage, file table was not updated correctly. In the provided fix, fresh data from the store is used during the store overriding.
Changes 🔄
How to test 🧪
As an Author I have considered 🤔
Check all that apply