Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [M3-8570] - Finish sunsetting Gravatar #10930

Merged
merged 6 commits into from
Sep 17, 2024

Conversation

mjac0bs
Copy link
Contributor

@mjac0bs mjac0bs commented Sep 12, 2024

Description 📝

This is a follow up from M3-8158 (#10859), which informed users with Gravatars of a sunset date of Sept 30 and transitioned users not currently using Gravatars to our new initial and color avatar icon.

This PR will remove Gravatar support for users who still have it on the communicated date.

Changes 🔄

  • Deletes a bunch of Gravatar-related components and utils
  • Uses our Avatar component only
  • Changes the username for system events or opened support tickets from "Linode" to "Akamai"

📸 Preview

Header Header
Screenshot 2024-09-16 at 9 16 33 AM Screenshot 2024-09-16 at 9 15 39 AM
Screenshot 2024-09-16 at 9 16 22 AM Screenshot 2024-09-16 at 9 15 48 AM
Opt2 Opt1

Target release date 🗓️

9/30/24

How to test 🧪

Prerequisites

(How to setup test environment)

  • Log in as an account with a Gravatar

Verification steps

(How to verify changes)

  • Go to the following locations in the app where we render avatars and confirm that you do not see your Gravatar anywhere:
    • Top Menu
    • Notification Center Event
    • Events Landing > Event Table Row
    • User Landing > User Table Row
    • User SSH Key Panel
    • Profile Display
    • Support Ticket Details (test this in dev with a dummy support ticket you comment on)
  • Confirm tests pass

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@mjac0bs mjac0bs self-assigned this Sep 12, 2024
@mjac0bs mjac0bs requested a review from a team as a code owner September 12, 2024 16:41
@mjac0bs mjac0bs requested review from dwiley-akamai and cpathipa and removed request for a team September 12, 2024 16:41
Copy link

github-actions bot commented Sep 12, 2024

Coverage Report:
Base Coverage: 86.64%
Current Coverage: 86.7%

Copy link
Contributor

@dwiley-akamai dwiley-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to finally arrive at the sunset 🌆

Code review ✅
Tests pass (the failing E2E test appears to be unrelated) ✅
On an account w/ a gravatar, I observed the avatar across the app instead ✅

@mjac0bs mjac0bs added the Add'tl Approval Needed Waiting on another approval! label Sep 13, 2024
@mjac0bs
Copy link
Contributor Author

mjac0bs commented Sep 16, 2024

Made one change (confirmed with UX) to update the username from "Linode" to "Akamai" in the places shown in the PR description. This better matches the Akamai logo and is consistent with our decision to favor "Akamai" branding throughout the app.

@mjac0bs mjac0bs added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! Ready for Review labels Sep 17, 2024
@mjac0bs
Copy link
Contributor Author

mjac0bs commented Sep 17, 2024

Unrelated CI e2e failure on a nodebalancer test + this test predates the component tests, so this is good to merge.

@mjac0bs mjac0bs merged commit 451d63a into linode:develop Sep 17, 2024
18 of 20 checks passed
nikhagra-akamai pushed a commit to nikhagra-akamai/manager that referenced this pull request Sep 23, 2024
* Clean up, clean up

* Remove missed clean up on Profile Details page

* Add changeset

* Use 'Akamai' instead of 'Linode' username for sys events

* Update unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants