change: [M3-8552] - eslint - mark formik as deprecated #10944
Conversation
abailly-akamai
requested review from
bnussman-akamai and
coliu-akamai
and removed request for
a team
|
Coverage Report: ✅ |
There was a problem hiding this comment.
✅ confirmed formik shown as deprecated
👀 confirmed composition section in the docs, but it shows up as 'Page Composition':
(we could also change Api to API 👀)
left a few small suggestions but lowkey lemme double check on the grammar 😓 (and lemme @mjac0bs 😆 🙏 )
|
@mjac0bs @coliu-akamai thanks for the attention to copy details! |
There was a problem hiding this comment.
Thank you for doing this, @abailly-akamai, and thanks for the great docs!
My only additional thought was: would it be useful to update the linter warning message to include a link the Form Composition section of the docs? If users are trying to use Formik, their next question might be: what are the patterns for RHF?
coliu-akamai
added
Approved
oops, I missed this one. I think that's a worthwhile update. will add before merging - thx for the suggestion @mjac0bs |
abailly-akamai
force-pushed
the
M3-8552
branch
from
a43d4a0 to
e7506e1
Compare
* initial commit: eslintrc rule * use eslint-plugin-cloud-manager * Documentation * Added changeset: Mark formik as deprecated * feedback @coliu-akamai
Description 📝
See linode/eslint-plugin-cloud-manager#6 for details about the new plugin
Changes 🔄
@linode/eslint-plugin-cloud-managerto^0.0.4Preview 📷
How to test 🧪
Verification steps
yarn docsand verify the new "Composition" section of our developer documentationAs an Author I have considered 🤔
Check all that apply