Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [M3-8589] - Flickering on the user profile page when updating the currently signed in user's username #10947

Merged
merged 3 commits into from
Sep 17, 2024
Merged

fix: [M3-8589] - Flickering on the user profile page when updating the currently signed in user's username #10947

merged 3 commits into from
Sep 17, 2024

Conversation

bnussman-akamai
Copy link
Member

@bnussman-akamai bnussman-akamai commented Sep 16, 2024 •
edited
Loading

Description 📝

  • Updates our cache updating logic on the useUpdateUserMutation hook to manually update the profile cache rather than invalidating it 🔧
  • This fixes 🔧 the bug 🐛 caught by @mjac0bs where the page would exhibit some flickering on the Delete button and Email fields when updating the username of the currently signed in user

Preview 📷

Before After
Screen.Recording.2024-09-16.at.1.24.15.PM.mov
Screen.Recording.2024-09-16.at.1.25.18.PM.mov

How to test 🧪

Prerequisites

  • Check out this PR or use the preview link
  • Go to the user profile of the currency signed in user
  • Try updating the username
  • Verify there is no flickering at all

As an Author I have considered 🤔

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@bnussman-akamai bnussman-akamai added the Bug Fixes for regressions or bugs label Sep 16, 2024
@bnussman-akamai bnussman-akamai self-assigned this Sep 16, 2024
@bnussman-akamai bnussman-akamai requested a review from a team as a code owner September 16, 2024 17:31
@bnussman-akamai bnussman-akamai requested review from hkhalil-akamai and abailly-akamai and removed request for a team September 16, 2024 17:31
@bnussman-akamai bnussman-akamai changed the title fix: [M3-8589] - Flickering on the User Profile page when updating the a User's Username fix: [M3-8589] - Flickering on the User Profile page when updating the currently signed in user's username Sep 16, 2024
@bnussman-akamai bnussman-akamai changed the title fix: [M3-8589] - Flickering on the User Profile page when updating the currently signed in user's username fix: [M3-8589] - Flickering on the user profile page when updating the currently signed in user's username Sep 16, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 16, 2024 •
edited
Loading

Coverage Report: ✅
Base Coverage: 86.7%
Current Coverage: 86.7%

mjac0bs
mjac0bs approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, the update is smooth now!

@mjac0bs mjac0bs added the Add'tl Approval Needed Waiting on another approval! label Sep 16, 2024
abailly-akamai
abailly-akamai approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, change looks good and fix confirmed ✅

Can we rerun the test suites for sanity?

@bnussman-akamai bnussman-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Sep 17, 2024
@bnussman-akamai bnussman-akamai merged commit 63ae19a into linode:develop Sep 17, 2024
18 of 20 checks passed
nikhagra-akamai pushed a commit to nikhagra-akamai/manager that referenced this pull request Sep 23, 2024
@bnussman-akamai @bnussman @nikhagra-akamai
fix: [M3-8589] - Flickering on the user profile page when updating th…
9864e4e 
…e currently signed in user's username (linode#10947)

* update the profile cache manually rather than doing an invalidation

* Added changeset: Flickering on the user profile page when updating the currently signed in user's username

---------

Co-authored-by: Banks Nussman <banks@nussman.us>
This was referenced Sep 25, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abailly-akamai abailly-akamai abailly-akamai approved these changes

@mjac0bs mjac0bs mjac0bs approved these changes

@hkhalil-akamai hkhalil-akamai Awaiting requested review from hkhalil-akamai hkhalil-akamai is a code owner automatically assigned from linode/frontend

Assignees

@bnussman-akamai bnussman-akamai

Labels
Approved Multiple approvals and ready to merge! Bug Fixes for regressions or bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bnussman-akamai @mjac0bs @abailly-akamai @bnussman