-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change: [M3-8593] - Copy updates in Create with CLI modal #10954
Conversation
This reverts commit b274baf.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
packages/manager/src/features/Linodes/LinodesCreate/ApiAwarenessModal/ApiAwarenessModal.tsx
Outdated
Show resolved
Hide resolved
@@ -88,11 +88,11 @@ export const ApiAwarenessModal = (props: ApiAwarenessModalProps) => { | |||
sendApiAwarenessClickEvent(`${type} Tab`, type); | |||
|
|||
const trackingKey = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this change going to have an impact on LD metrics? (I'm guessing we'll just be able to aggregate the numbers from pre and post typo fix?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no impact on LD metrics. This will check the condition to fire the LD event with the appropriate key. In this case, we have also updated the check condition with respect to the tab name SDKs.
Coverage Report: ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks Chandra! approving pending Mariah's comments are resolved/answered 🎉
✅ confirmed copy update for 'Getting Started'
✅ confirmed copy update for SDKs
…ssModal/ApiAwarenessModal.tsx Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
@cpathipa There are two Cypress failures on this branch, and at least one is probably legit, because I'm sure we were testing the previous copy. Can you confirm this is flake or fix:
|
Thanks @mjac0bs updated the create-linode-view-code-snippet.spec file 7ac5957, And lan-selection.spec passed running in local. |
Description 📝
Highlight the Pull Request's context and intentions.
Changes 🔄
List any change relevant to the reviewer.
Target release date 🗓️
9/30
Verification steps
(How to verify changes)
As an Author I have considered 🤔
Check all that apply