-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tech story: Update dompurify and jsPDF to fix dependabot alert #10955
tech story: Update dompurify and jsPDF to fix dependabot alert #10955
Conversation
Coverage Report: ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GHA ✅ (the two failing E2E tests seem to be flakes)
No issues with yarn.lock
locally ✅
update: saw that a jsPDF update just came out to address the dompurify security concern - v2.5.2. I've updated jsPDF on my branch + checked that all tests pass. There shouldn't be any breaking changes based on the release notes, but will be trying to test with generating invoices as well before pushing it up! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you 📦
@bnussman-akamai @dwiley-akamai just pushed up a change to update jsPDF as well - would you be able to rereview with a focus that there are no regressions in invoice generation 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed yarn.lock
looks good and PDF invoices are also good ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Invoice PDFs look good to me as well 🚢
Description 📝
Fixes dependabot alert here: https://github.com/linode/manager/security/dependabot/121
See #10953 for context
Changes 🔄
How to test 🧪
As an Author I have considered 🤔
Check all that apply