Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [M3-8581] - GPUv2 Plan Selection Egress Banner #10956

Merged
merged 6 commits into from
Sep 25, 2024

Conversation

abailly-akamai
Copy link
Contributor

@abailly-akamai abailly-akamai commented Sep 17, 2024

Description 📝

Small PR to add a GPUv2 Banner for the 9/30 new GPU plans launch. This is the MVP for the initial launch, before modifying the Plans Panel to account for transfer and billing changes.

Note

This is very much a temp banner, which is the reason for not adding the banner to the existing e2e coverage. It will be removed in an upcoming M2 update.

Changes 🔄

  • Add new egressBanner property to the GPUv2 flag object
  • Add new banner behind flag conditional

Target release date 🗓️

9/30/2024

Preview 📷

Linodes create

How to test 🧪

Important

You may want the gpuv2beta flag on your account to get the new GPUv2 plans to show up, but it is not a requirement for testing the display of the banner

Verification steps

  • Make sure the gpuv2 flag is on
  • Navigate to the Linode Create flow, and verify the following:
    • This notice shall be consistent for the entire length of the promotion regardless of region if the user selects the GPU plan type
    • The notice should display wether the user has picked a region or not
    • This notice shall appear at the top, first sequentially before any other notices as relevant
    • The banner should not impact the logic / display of the other banners

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@abailly-akamai abailly-akamai self-assigned this Sep 17, 2024
@abailly-akamai abailly-akamai force-pushed the M3-8581 branch 2 times, most recently from bd4f857 to a63f76f Compare September 23, 2024 14:45
@abailly-akamai abailly-akamai marked this pull request as ready for review September 23, 2024 14:53
@abailly-akamai abailly-akamai requested a review from a team as a code owner September 23, 2024 14:53
@abailly-akamai abailly-akamai requested review from bnussman-akamai and coliu-akamai and removed request for a team September 23, 2024 14:53
@abailly-akamai abailly-akamai changed the title feat: [M3-8581] - GPUv2 M1 Egress Banner feat: [M3-8581] - GPUv2 Plan Selection Egress Banner Sep 23, 2024
Copy link

github-actions bot commented Sep 23, 2024

Coverage Report:
Base Coverage: 86.98%
Current Coverage: 86.98%

Copy link
Member

@bnussman-akamai bnussman-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Banner looks good ✅ Left some non-blocking optional feedback

Copy link
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ confirmed GPUv2 banner + the bullet points regarding it

thanks Alban! 🎉

@coliu-akamai coliu-akamai added the Approved Multiple approvals and ready to merge! label Sep 24, 2024
@abailly-akamai abailly-akamai requested a review from a team as a code owner September 25, 2024 18:00
@abailly-akamai abailly-akamai requested review from AzureLatte and removed request for a team September 25, 2024 18:00
@abailly-akamai abailly-akamai merged commit a6bd924 into linode:develop Sep 25, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants