-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump vite to 5.4.6 #10960
chore: bump vite to 5.4.6 #10960
Conversation
@jdamore-linode component test suite passes locally - confused why it wouldn't here - any clue? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we update vitest
in our other packages too?
@bnussman yeah always forget. We're in a monorepo, why do we have three of the same dependency in our own packages? |
We might be able to specify it as a top level but I think it's generally better to specify it at each package level. Some solutions out there might exist like pnpm/pnpm#2713 (comment) This is something we can look deeper into as part of the modularization |
can you clarify why? |
Coverage Report: ✅ |
I suppose it wouldn't hurt to move it. I was just worried about making Edit: I took a look at some other open source projects and many of them did infact have testing tools in the root package.json, so I'm cool with it if we want to try that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Things look good aside from the test checks and yarn.lock
conflict
c1d13fe
to
4ae215c
Compare
@bnussman-akamai sounds good - i'll make a ticket to identify a few deps that could be rooted. I think limiting to a few key dev dependencies would be a good first step |
Can you rerun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for doing this! 🚀
Confirmed the e2e failures are unrelated and passing locally |
Description 📝
Bumps vite and vite related packages
we have slew of new dep vulnerabilities, and while this is all dev vulnerabilities, this one looks like an easy target.
opening in favor of the dependabot PR: #10957 in order to have all suites running easily
Changes 🔄
How to test 🧪
Verification steps