Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump vite to 5.4.6 #10960

Merged
merged 4 commits into from
Sep 19, 2024

Conversation

abailly-akamai
Copy link
Contributor

@abailly-akamai abailly-akamai commented Sep 18, 2024

Description 📝

Bumps vite and vite related packages

we have slew of new dep vulnerabilities, and while this is all dev vulnerabilities, this one looks like an easy target.

opening in favor of the dependabot PR: #10957 in order to have all suites running easily

Changes 🔄

  • bump vite and vite related packages to latest versions

How to test 🧪

Verification steps

  • make sure app and test suites get no regression from PR

@abailly-akamai abailly-akamai self-assigned this Sep 18, 2024
@abailly-akamai abailly-akamai marked this pull request as ready for review September 18, 2024 13:32
@abailly-akamai abailly-akamai requested a review from a team as a code owner September 18, 2024 13:32
@abailly-akamai abailly-akamai requested review from dwiley-akamai and cpathipa and removed request for a team September 18, 2024 13:32
@abailly-akamai
Copy link
Contributor Author

@jdamore-linode component test suite passes locally - confused why it wouldn't here - any clue?

Copy link
Contributor

@bnussman bnussman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we update vitest in our other packages too?

@abailly-akamai
Copy link
Contributor Author

abailly-akamai commented Sep 18, 2024

@bnussman yeah always forget. We're in a monorepo, why do we have three of the same dependency in our own packages?

@bnussman-akamai
Copy link
Member

We might be able to specify it as a top level but I think it's generally better to specify it at each package level.

Some solutions out there might exist like pnpm/pnpm#2713 (comment)

This is something we can look deeper into as part of the modularization

@abailly-akamai
Copy link
Contributor Author

I think it's generally better to specify it at each package level

can you clarify why?

Copy link

github-actions bot commented Sep 18, 2024

Coverage Report:
Base Coverage: 86.93%
Current Coverage: 86.93%

@bnussman-akamai
Copy link
Member

bnussman-akamai commented Sep 18, 2024

I suppose it wouldn't hurt to move it. I was just worried about making vitest available to any package within the monorepo and if that would have any unintended side effects. Not sure if there is any value in keeping each package's package.json representative of what it actually depends on

Edit: I took a look at some other open source projects and many of them did infact have testing tools in the root package.json, so I'm cool with it if we want to try that

Copy link
Contributor

@dwiley-akamai dwiley-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things look good aside from the test checks and yarn.lock conflict

@abailly-akamai
Copy link
Contributor Author

@bnussman-akamai sounds good - i'll make a ticket to identify a few deps that could be rooted. I think limiting to a few key dev dependencies would be a good first step

@bnussman-akamai
Copy link
Member

Can you rerun yarn and push up the lockfile changes? Seeing a diff when I run yarn locally

Copy link
Member

@bnussman-akamai bnussman-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for doing this! 🚀

@coliu-akamai coliu-akamai added Dependencies Pull requests that update a dependency file Approved Multiple approvals and ready to merge! labels Sep 18, 2024
@abailly-akamai
Copy link
Contributor Author

Confirmed the e2e failures are unrelated and passing locally

@abailly-akamai abailly-akamai merged commit 2556a99 into linode:develop Sep 19, 2024
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants