-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: [M3-8616] - Fix failures in DBaaS update tests #10975
test: [M3-8616] - Fix failures in DBaaS update tests #10975
Conversation
Coverage Report: ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going forward we might want to discourage using pickRandom or any similar utils that make our factories less deterministic since they're used throughout the codebase/tests
@jdamore-linode - Should we call this out in our docs?
Thanks for the quick investigation and fixes - I did observe this passing 5/5 times locally.
Merging despite test failures:
|
Description 📝
Recent improvements made for DBaaS v2 began causing intermittent test failures in
update-database.spec.ts
. This PR makes a few changes to resolve these failures:dbaasV2
feature flag to be disabledManaged Databases Beta
capabilityplatform
field to always reflect the legacy platformpickRandom
or any similar utils that make our factories less deterministic since they're used throughout the codebase/testsTarget release date 🗓️
N/A
How to test 🧪
We can't rely solely on CI for this since this failure is only intermittent, but running the tests in
update-database.spec.ts
a few times in a row without observing any failures can help increase confidence that the tests are fixed.repeat 3 yarn cy:run -s "cypress/e2e/core/databases/update-database.spec.ts"
As an Author I have considered 🤔
Check all that apply